Shade jackson in vortex-jni and vortex-spark and avoid scala version conflicts#7168
Merged
robert3005 merged 6 commits intodevelopfrom Mar 26, 2026
Merged
Shade jackson in vortex-jni and vortex-spark and avoid scala version conflicts#7168robert3005 merged 6 commits intodevelopfrom
robert3005 merged 6 commits intodevelopfrom
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
a10y
approved these changes
Mar 25, 2026
Contributor
Author
|
There's still some sadness I'm trying to figure out here |
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Java dependencies work in mysterious ways but mostly it's jackson-scala that's
to blame. Because scala-lang is just a versioned library and 2.13 > 2.12 I had to remove consistent-versions since they specifically forbid doing the thing we need to - have two conflicting version sets across spark versions
Signed-off-by: Robert Kruszewski github@robertk.io