Skip to content

Shade jackson in vortex-jni and vortex-spark and avoid scala version conflicts#7168

Merged
robert3005 merged 6 commits intodevelopfrom
rk/spark
Mar 26, 2026
Merged

Shade jackson in vortex-jni and vortex-spark and avoid scala version conflicts#7168
robert3005 merged 6 commits intodevelopfrom
rk/spark

Conversation

@robert3005
Copy link
Contributor

@robert3005 robert3005 commented Mar 25, 2026

Java dependencies work in mysterious ways but mostly it's jackson-scala that's
to blame. Because scala-lang is just a versioned library and 2.13 > 2.12 I had to remove consistent-versions since they specifically forbid doing the thing we need to - have two conflicting version sets across spark versions

Signed-off-by: Robert Kruszewski github@robertk.io

@robert3005 robert3005 requested a review from a10y March 25, 2026 21:38
@robert3005 robert3005 added the changelog/fix A bug fix label Mar 25, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 25, 2026

Merging this PR will not alter performance

✅ 1106 untouched benchmarks
⏩ 1522 skipped benchmarks1


Comparing rk/spark (897bdfe) with develop (7852ece)

Open in CodSpeed

Footnotes

  1. 1522 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@robert3005
Copy link
Contributor Author

There's still some sadness I'm trying to figure out here

Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 changed the title Shade jackson in vortex-jni and vortex-spark Shade jackson in vortex-jni and vortex-spark and avoid scala version conflicts Mar 26, 2026
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 enabled auto-merge (squash) March 26, 2026 03:45
@robert3005 robert3005 merged commit 37bb73d into develop Mar 26, 2026
58 checks passed
@robert3005 robert3005 deleted the rk/spark branch March 26, 2026 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants