use trait upcasting and drop the as_any/as_any_mut boilerplate#7220
Open
use trait upcasting and drop the as_any/as_any_mut boilerplate#7220
Conversation
robert3005
approved these changes
Mar 31, 2026
AdamGS
approved these changes
Mar 31, 2026
Merging this PR will degrade performance by 75.14%
Performance Changes
Comparing Footnotes
|
Contributor
|
it's interesting that this had changed execution of take benchmarks? |
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Rust 1.86 (which is before our MSRV) there has been builtin trait upcasting, meaning instead of forcing all our traits to have a dummy
fn as_any(&self) -> &dyn Anymethods with trivial impls, we can instead just take a pointer to the trait object and doas &dyn Any.This reduces the amount of boilerplate in trait impls, which is nice. Another benefit is that in the past blanket impls like
SessionVarwould end up getting pulled in for dispatch of calls to as_any() which has caused me frustration. Now the dispatch is clearer.This isn't a breaking change b/c it doesn't touch the VTables, which is the implementer surface area