Draft
Conversation
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continuation of #7107.
Since we want to add a bunch of new vector encodings that rely on unit normalization (spherical transform, turboquant), we would like to introduce this as an encoding.
Note that once we eventually have #6717, the operations will be a lot less ugly.
Also, we can only do the broadcasting trick with
RunEndandSequencearray multiplication on the decompress side, we can't do it on the compress side because we may potentially divide by 0 (and we can't intercept that and say return 0 in that case).There is an open question on if, instead of representing this as a physical encoding, we should have scalar encodings like this one (others include FoR and ZigZag) be scalar functions. Whatever we decide, we should probably just merge this first as we can always change this later.
Open Questions
API Changes
Adds a new vector encoding to the
vortex-tensorcrate.Testing
Basic tests.