Skip to content

Array VTables Follow Up#7276

Merged
gatesn merged 15 commits intodevelopfrom
ngates/vtable-cleanup
Apr 3, 2026
Merged

Array VTables Follow Up#7276
gatesn merged 15 commits intodevelopfrom
ngates/vtable-cleanup

Conversation

@gatesn
Copy link
Copy Markdown
Contributor

@gatesn gatesn commented Apr 3, 2026

This PR follows #7215

gatesn added 8 commits April 2, 2026 16:24
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn added changelog/chore A trivial change changelog/break A breaking API change and removed changelog/chore A trivial change labels Apr 3, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 3, 2026

Merging this PR will degrade performance by 21.81%

⚡ 2 improved benchmarks
❌ 9 regressed benchmarks
✅ 1111 untouched benchmarks
⏩ 1530 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation new_alp_prim_test_between[f64, 2048] 64 µs 75.6 µs -15.34%
Simulation new_bp_prim_test_between[i64, 2048] 54.7 µs 64.9 µs -15.74%
Simulation new_bp_prim_test_between[i64, 32768] 231.5 µs 179.8 µs +28.75%
Simulation new_bp_prim_test_between[i64, 16384] 109.6 µs 140.1 µs -21.81%
Simulation new_bp_prim_test_between[i32, 32768] 138.8 µs 158.7 µs -12.53%
Simulation new_bp_prim_test_between[i32, 16384] 93.1 µs 104.7 µs -11.03%
Simulation take_10k_random 192 µs 240 µs -20%
Simulation patched_take_10k_first_chunk_only 329.4 µs 274.1 µs +20.17%
Simulation take_10k_contiguous 269.8 µs 316.5 µs -14.73%
Simulation decompress_rd[f32, (10000, 0.1)] 82.5 µs 93.2 µs -11.39%
Simulation decompress_rd[f32, (10000, 0.01)] 82.3 µs 93.2 µs -11.62%

Comparing ngates/vtable-cleanup (7c578bf) with develop (a8351a9)

Open in CodSpeed

Footnotes

  1. 1530 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

gatesn added 3 commits April 3, 2026 14:02
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn marked this pull request as ready for review April 3, 2026 18:07
gatesn added 4 commits April 3, 2026 14:18
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn merged commit bf97ba2 into develop Apr 3, 2026
60 of 62 checks passed
@gatesn gatesn deleted the ngates/vtable-cleanup branch April 3, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/break A breaking API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants