Implement compare/between for bitpacked arrays - improve performance by up to 2X#7279
Draft
Implement compare/between for bitpacked arrays - improve performance by up to 2X#7279
Conversation
Merging this PR will improve performance by ×2.5
Performance Changes
Comparing 
Footnotes
|
AdamGS
force-pushed
the
adamg/bitpack-compare
branch
from
74732ef to
8cddde0
Compare
github-actions
bot
removed
the
action/benchmark-sql
Contributor
Polar Signals Profiling ResultsLatest Run
Previous Runs (7)
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingVortex (geomean): 1.130x ❌ datafusion / vortex-file-compressed (1.130x ❌, 0↑ 8↓)
|
Contributor
Benchmarks: TPC-H SF=1 on NVMEVerdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (1.148x ❌, 0↑ 19↓)
datafusion / vortex-compact (1.147x ❌, 0↑ 21↓)
datafusion / parquet (1.096x ➖, 1↑ 11↓)
datafusion / arrow (1.171x ❌, 0↑ 18↓)
duckdb / vortex-file-compressed (1.125x ❌, 0↑ 14↓)
duckdb / vortex-compact (1.114x ❌, 0↑ 14↓)
duckdb / parquet (1.004x ➖, 2↑ 2↓)
duckdb / duckdb (1.112x ❌, 0↑ 11↓)
Full attributed analysis
|
Contributor
Benchmarks: FineWeb NVMeVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.989x ➖, 0↑ 1↓)
datafusion / vortex-compact (1.006x ➖, 0↑ 0↓)
datafusion / parquet (1.014x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.004x ➖, 1↑ 0↓)
duckdb / vortex-compact (1.001x ➖, 0↑ 0↓)
duckdb / parquet (1.006x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.964x ➖, 8↑ 0↓)
datafusion / vortex-compact (0.987x ➖, 1↑ 1↓)
datafusion / parquet (1.003x ➖, 5↑ 6↓)
duckdb / vortex-file-compressed (0.973x ➖, 4↑ 1↓)
duckdb / vortex-compact (0.971x ➖, 4↑ 0↓)
duckdb / parquet (0.966x ➖, 6↑ 1↓)
duckdb / duckdb (0.978x ➖, 3↑ 0↓)
Full attributed analysis
|
Contributor
Benchmarks: TPC-H SF=10 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.995x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.995x ➖, 0↑ 0↓)
datafusion / parquet (1.004x ➖, 0↑ 0↓)
datafusion / arrow (1.014x ➖, 0↑ 1↓)
duckdb / vortex-file-compressed (0.979x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.996x ➖, 0↑ 0↓)
duckdb / parquet (0.990x ➖, 0↑ 0↓)
duckdb / duckdb (1.001x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
Benchmarks: Statistical and Population GeneticsVerdict: No clear signal (low confidence) duckdb / vortex-file-compressed (0.956x ➖, 1↑ 0↓)
duckdb / vortex-compact (0.997x ➖, 0↑ 0↓)
duckdb / parquet (0.987x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
Benchmarks: Clickbench on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.983x ➖, 0↑ 1↓)
datafusion / parquet (0.997x ➖, 0↑ 1↓)
duckdb / vortex-file-compressed (1.031x ➖, 2↑ 6↓)
duckdb / parquet (0.995x ➖, 0↑ 0↓)
duckdb / duckdb (0.970x ➖, 2↑ 1↓)
Full attributed analysis
|
Contributor
Benchmarks: FineWeb S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (1.122x ➖, 0↑ 1↓)
datafusion / vortex-compact (1.102x ➖, 0↑ 0↓)
datafusion / parquet (1.035x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.023x ➖, 1↑ 1↓)
duckdb / vortex-compact (1.083x ➖, 0↑ 0↓)
duckdb / parquet (1.031x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
Benchmarks: TPC-H SF=1 on S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (1.058x ➖, 2↑ 5↓)
datafusion / vortex-compact (1.001x ➖, 1↑ 3↓)
datafusion / parquet (0.928x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.001x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.986x ➖, 0↑ 0↓)
duckdb / parquet (1.036x ➖, 0↑ 0↓)
Full attributed analysis
|
github-actions
bot
removed
the
action/benchmark-sql
Contributor
Benchmarks: TPC-H SF=10 on S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (0.881x ➖, 1↑ 0↓)
datafusion / vortex-compact (1.024x ➖, 0↑ 2↓)
datafusion / parquet (1.060x ➖, 2↑ 3↓)
duckdb / vortex-file-compressed (0.978x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.889x ➖, 1↑ 0↓)
duckdb / parquet (0.965x ➖, 0↑ 1↓)
Full attributed analysis
|
github-actions
bot
removed
the
action/benchmark-sql
AdamGS
force-pushed
the
adamg/bitpack-compare
branch
2 times, most recently
from
a103738 to
4454bc6
Compare
AdamGS
changed the title
AdamGS
force-pushed
the
adamg/bitpack-compare
branch
2 times, most recently
from
52289bf to
dbe5a37
Compare
github-actions
bot
removed
the
action/benchmark
AdamGS
force-pushed
the
adamg/bitpack-compare
branch
from
dbe5a37 to
33e6d30
Compare
Contributor
Benchmarks: Random AccessVortex (geomean): 0.841x ✅ unknown / unknown (0.915x ➖, 16↑ 0↓)
|
github-actions
bot
removed
the
action/benchmark
Contributor
Benchmarks: CompressionVortex (geomean): 1.014x ➖ unknown / unknown (1.005x ➖, 2↑ 4↓)
|
Contributor
File Sizes: PolarSignals ProfilingNo baseline file sizes available yet. |
Contributor
File Sizes: TPC-H SF=1 on NVMENo baseline file sizes available yet. |
Contributor
File Sizes: FineWeb NVMeNo baseline file sizes available yet. |
Contributor
File Sizes: TPC-DS SF=1 on NVMENo baseline file sizes available yet. |
Contributor
File Sizes: TPC-H SF=10 on NVMENo baseline file sizes available yet. |
Contributor
File Sizes: Statistical and Population GeneticsNo baseline file sizes available yet. |
github-actions
bot
removed
the
action/benchmark
Contributor
File Sizes: Clickbench on NVMENo baseline file sizes available yet. |
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
AdamGS
force-pushed
the
adamg/bitpack-compare
branch
from
2573b0e to
a7a7eea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After some iterations, this seems to improve performance in any case we actually measure. It does require merging and releasing spiraldb/fastlanes#125.