Skip to content

Tensor Matchers#7300

Merged
connortsui20 merged 2 commits intodevelopfrom
ct/vector-match
Apr 6, 2026
Merged

Tensor Matchers#7300
connortsui20 merged 2 commits intodevelopfrom
ct/vector-match

Conversation

@connortsui20
Copy link
Copy Markdown
Contributor

Summary

Instead of having weird helper functions extract information out of the FSL dtype, we can extract it into new matcher metadata via AnyVector and AnyFixedShapeTensor matchers.

Note that this is separate from the metadata that needs to be serialized to disk on the array vtable.

Testing

N/A since the logic should be the same, just in a different place.

@connortsui20 connortsui20 requested a review from gatesn April 6, 2026 20:25
@connortsui20 connortsui20 added the changelog/feature A new feature label Apr 6, 2026
@connortsui20 connortsui20 force-pushed the ct/vector-match branch 2 times, most recently from d4305ae to ddf1bb4 Compare April 6, 2026 21:09
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 6, 2026

Merging this PR will not alter performance

✅ 1122 untouched benchmarks
⏩ 1530 skipped benchmarks1


Comparing ct/vector-match (c67a6bd) with develop (cca6e9e)

Open in CodSpeed

Footnotes

  1. 1530 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 merged commit 0170156 into develop Apr 6, 2026
62 checks passed
@connortsui20 connortsui20 deleted the ct/vector-match branch April 6, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants