Skip to content

ArrayPlugin#7302

Merged
gatesn merged 2 commits intodevelopfrom
ngates/plugin
Apr 6, 2026
Merged

ArrayPlugin#7302
gatesn merged 2 commits intodevelopfrom
ngates/plugin

Conversation

@gatesn
Copy link
Copy Markdown
Contributor

@gatesn gatesn commented Apr 6, 2026

Rename / clean up to match other VTable designs and make it easier to implement custom Array deserializers.

Signed-off-by: Nicholas Gates <nick@nickgates.com>
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 6, 2026

Merging this PR will degrade performance by 69.63%

⚡ 24 improved benchmarks
❌ 15 regressed benchmarks
✅ 1083 untouched benchmarks
⏩ 1530 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation take_search[(0.005, 0.05)] 168.8 µs 131.6 µs +28.23%
Simulation take_search[(0.005, 1.0)] 3.1 ms 2.3 ms +31.28%
Simulation take_search[(0.01, 1.0)] 3.3 ms 2.5 ms +28.79%
Simulation take_search[(0.005, 0.1)] 320.7 µs 247.1 µs +29.77%
Simulation take_search[(0.005, 0.5)] 1.5 ms 1.2 ms +31.07%
Simulation take_search[(0.01, 0.05)] 179.9 µs 142.7 µs +26.04%
Simulation take_search[(0.01, 0.1)] 341.5 µs 267.9 µs +27.46%
Simulation take_search[(0.01, 0.5)] 1.6 ms 1.3 ms +28.62%
Simulation take_search[(0.1, 0.05)] 249.7 µs 212.5 µs +17.49%
Simulation take_search[(0.1, 0.1)] 460.2 µs 386.5 µs +19.05%
Simulation take_search_chunked[(0.005, 0.05)] 197.6 µs 165.9 µs +19.05%
Simulation take_search_chunked[(0.01, 0.1)] 401.6 µs 339 µs +18.45%
Simulation take_search_chunked[(0.1, 0.05)] 276.4 µs 244.7 µs +12.92%
Simulation take_search_chunked[(0.1, 0.5)] 2.4 ms 2.1 ms +14.74%
Simulation take_search_chunked[(0.1, 0.1)] 512.6 µs 450.1 µs +13.89%
Simulation take_search_chunked[(0.01, 0.5)] 1.9 ms 1.6 ms +19.06%
Simulation take_search_chunked[(0.01, 0.05)] 210.5 µs 178.9 µs +17.67%
Simulation take_search[(0.1, 1.0)] 4.3 ms 3.5 ms +20.66%
Simulation take_search_chunked[(0.01, 1.0)] 3.9 ms 3.2 ms +19.15%
Simulation take_search_chunked[(0.005, 0.1)] 377.2 µs 314.6 µs +19.88%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.


Comparing ngates/plugin (d1eb2e5) with develop (cca6e9e)

Open in CodSpeed

Footnotes

  1. 1530 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@gatesn gatesn added the changelog/chore A trivial change label Apr 6, 2026
Comment on lines +34 to +43
fn deserialize(
&self,
dtype: &DType,
len: usize,
metadata: &[u8],
buffers: &[BufferHandle],
children: &dyn ArrayChildren,
session: &VortexSession,
) -> VortexResult<ArrayRef>;
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is exactly what i need

Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn enabled auto-merge (squash) April 6, 2026 21:30
@gatesn gatesn merged commit de4eb39 into develop Apr 6, 2026
107 of 109 checks passed
@gatesn gatesn deleted the ngates/plugin branch April 6, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants