Skip to content

fix[vortex-array]: fix offset_within_chunk underflow on patches array#7312

Merged
robert3005 merged 1 commit intodevelopfrom
asubiotto/patches
Apr 7, 2026
Merged

fix[vortex-array]: fix offset_within_chunk underflow on patches array#7312
robert3005 merged 1 commit intodevelopfrom
asubiotto/patches

Conversation

@asubiotto
Copy link
Copy Markdown
Contributor

slice_start_idx was missing normalization to absolute coordinates.

Summary

Testing

@asubiotto asubiotto requested review from 0ax1 and robert3005 April 7, 2026 11:51
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 7, 2026

Merging this PR will improve performance by 20.89%

⚡ 1 improved benchmark
✅ 1121 untouched benchmarks
⏩ 1530 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_bool_canonical_into[(1000, 10)] 60.3 µs 49.9 µs +20.89%

Comparing asubiotto/patches (f29c09b) with develop (951bdf9)

Open in CodSpeed

Footnotes

  1. 1530 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@asubiotto asubiotto added the changelog/fix A bug fix label Apr 7, 2026
slice_start_idx was missing normalization to absolute coordinates.

Signed-off-by: Alfonso Subiotto Marques <alfonso.subiotto@polarsignals.com>
@asubiotto asubiotto force-pushed the asubiotto/patches branch from fb0345d to f29c09b Compare April 7, 2026 13:27
Copy link
Copy Markdown
Contributor

@robert3005 robert3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explaining it to me

@robert3005 robert3005 merged commit 6c7eb33 into develop Apr 7, 2026
64 of 65 checks passed
@robert3005 robert3005 deleted the asubiotto/patches branch April 7, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants