fix[vortex-array]: fix offset_within_chunk underflow on patches array#7312
Merged
robert3005 merged 1 commit intodevelopfrom Apr 7, 2026
Merged
fix[vortex-array]: fix offset_within_chunk underflow on patches array#7312robert3005 merged 1 commit intodevelopfrom
robert3005 merged 1 commit intodevelopfrom
Conversation
Merging this PR will improve performance by 20.89%
Performance Changes
Comparing Footnotes
|
robert3005
reviewed
Apr 7, 2026
slice_start_idx was missing normalization to absolute coordinates. Signed-off-by: Alfonso Subiotto Marques <alfonso.subiotto@polarsignals.com>
fb0345d to
f29c09b
Compare
robert3005
approved these changes
Apr 7, 2026
Contributor
robert3005
left a comment
There was a problem hiding this comment.
Thanks for explaining it to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
slice_start_idx was missing normalization to absolute coordinates.
Summary
Testing