Skip to content

Pull out L2Denorm from TurboQuant#7349

Merged
connortsui20 merged 4 commits intodevelopfrom
ct/tq-norm
Apr 8, 2026
Merged

Pull out L2Denorm from TurboQuant#7349
connortsui20 merged 4 commits intodevelopfrom
ct/tq-norm

Conversation

@connortsui20
Copy link
Copy Markdown
Contributor

Summary

Tracking issue: #7297

This is the first step in decomposing TurboQuant as 2 scalar fns on top of a dictionary.

We would like to (soon) decompose TurboQuant into a Scheme that roughly constructs the following array tree:

L2Denorm(
    norms,
    SorfTransform(
        rotation_signs,
        Dict(
            codes, (indices into centroids)
            values, (centroid book)
        ),
    ),
)

This is the outer layer.

Testing

The logic is the same so existing tests suffice.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 8, 2026

Merging this PR will not alter performance

✅ 1122 untouched benchmarks
⏩ 1530 skipped benchmarks1


Comparing ct/tq-norm (9cb5c35) with develop (0e9c0c5)

Open in CodSpeed

Footnotes

  1. 1530 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 force-pushed the ct/tq-norm branch 2 times, most recently from da5eff3 to b81d20b Compare April 8, 2026 20:25
@connortsui20 connortsui20 marked this pull request as ready for review April 8, 2026 20:25
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 enabled auto-merge (squash) April 8, 2026 20:32
@connortsui20 connortsui20 merged commit eacb959 into develop Apr 8, 2026
60 checks passed
@connortsui20 connortsui20 deleted the ct/tq-norm branch April 8, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants