Conversation
Merging this PR will not alter performance
Comparing 
Footnotes
|
connortsui20
force-pushed
the
ct/remove-metadata
branch
from
ad7e67a to
5ad3c47
Compare
| } | ||
| let concat = concat.freeze(); | ||
| session.arrays().register(ParquetVariant); | ||
| session.arrays().register(Variant); |
There was a problem hiding this comment.
ParquetVariant is registered above.
Variant is the canonical array, it's now registrered in default ArraySession
connortsui20
force-pushed
the
ct/remove-metadata
branch
from
5ad3c47 to
7f55d36
Compare
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
force-pushed
the
ct/remove-metadata
branch
from
7f55d36 to
c897b28
Compare
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
| @@ -292,7 +292,7 @@ impl PyVortexWriteOptions { | |||
| /// ```python | |||
| /// >>> vx.io.VortexWriteOptions.compact().write(sprl, "tiny.vortex") | |||
| /// >>> os.path.getsize('tiny.vortex') | |||
| /// 55120 | |||
| /// 55152 | |||
There was a problem hiding this comment.
@gatesn is this expected with only the changes in this PR?
| #[test] | ||
| fn unknown_array_encoding_allow_unknown() { |
There was a problem hiding this comment.
this test didnt actually test anything, and was broken
Size change is attributed to us always serializing the IDs of all encodings that exist in the registry. This PR adds dict + variant (which should have been there all along!!) |
3 participants
Summary
Apparently we just don't need this now? And we want to use
array_serializeto get metadata instead.This also fixes a few incorrect tests that we had.
API Changes
Removes the
metadatamethod onDynArray.Testing
Fixes some tests.