Support serializion tensor scalar fns#7437
Merged
connortsui20 merged 2 commits intodevelopfrom Apr 15, 2026
Merged
Conversation
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
gatesn
approved these changes
Apr 14, 2026
|
|
||
| static SESSION: LazyLock<VortexSession> = | ||
| LazyLock::new(|| VortexSession::empty().with::<ArraySession>()); | ||
| static SESSION: LazyLock<VortexSession> = LazyLock::new(|| { |
Contributor
There was a problem hiding this comment.
Most crates put this in a mod tests { .. } in lib.rs, then share across all tests in the crate.
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Merging this PR will degrade performance by 23.16%
Performance Changes
Comparing Footnotes
|
Contributor
Author
|
whoops I forgot to push my env variable changes, so technically anyone can write them now |
Contributor
Author
|
I have changes here but they require some stuff that isnt on develop yet: f37e388 Will figure this out tomorrow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tracking issue: #7297
Adds serialization support to the tensor scalar fns. This is gated by the
VORTEX_TENSOR_SCALAR_FN_ARRAY_PLUGINSenvironment variable.Testing
Basic testing.
Unresolved Questions
SorfTransformMetadatawhen it is basically identical toSorfOptionsbut with prost.