Skip to content

Remove ListViewBuilder scalar_at#7438

Merged
gatesn merged 1 commit intodevelopfrom
ngates/list-view-builder
Apr 14, 2026
Merged

Remove ListViewBuilder scalar_at#7438
gatesn merged 1 commit intodevelopfrom
ngates/list-view-builder

Conversation

@gatesn
Copy link
Copy Markdown
Contributor

@gatesn gatesn commented Apr 14, 2026

Benchmark Before (median) After (median) Speedup
extend_from_array_non_zctl_overlapping (1000, 8) 902.2 µs 63.66 µs 14.17x
extend_from_array_non_zctl_overlapping (1000, 32) 2.446 ms 76.54 µs 31.96x
extend_from_array_non_zctl_overlapping (10000, 8) 9.821 ms 561.5 µs 17.49x
extend_from_array_zctl (1000, 8) 1.057 ms 13.95 µs 75.77x
extend_from_array_zctl (1000, 64) 5.416 ms 38.29 µs 141.45x
extend_from_array_zctl (10000, 8) 10.52 ms 111.3 µs 94.52x

Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn requested a review from joseph-isaacs April 14, 2026 22:43
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 14, 2026

Merging this PR will degrade performance by 14.79%

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 1145 untouched benchmarks
🆕 6 new benchmarks
⏩ 1455 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
🆕 Simulation extend_from_array_non_zctl_overlapping[(1000, 32)] N/A 1.2 ms N/A
🆕 Simulation extend_from_array_non_zctl_overlapping[(10000, 8)] N/A 6.1 ms N/A
🆕 Simulation extend_from_array_non_zctl_overlapping[(1000, 8)] N/A 695.2 µs N/A
🆕 Simulation extend_from_array_zctl[(10000, 8)] N/A 2.5 ms N/A
🆕 Simulation extend_from_array_zctl[(1000, 8)] N/A 306.5 µs N/A
🆕 Simulation extend_from_array_zctl[(1000, 64)] N/A 1.2 ms N/A
Simulation old_alp_prim_test_between[f32, 32768] 269.1 µs 223.2 µs +20.6%
Simulation new_alp_prim_test_between[f64, 16384] 127.6 µs 149.7 µs -14.79%

Comparing ngates/list-view-builder (bec9229) with develop (f747201)

Open in CodSpeed

Footnotes

  1. 1455 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link
Copy Markdown
Contributor

@robert3005 robert3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great

@gatesn gatesn added the changelog/performance A performance improvement label Apr 14, 2026
@gatesn gatesn enabled auto-merge (squash) April 14, 2026 22:50
@gatesn gatesn merged commit c4ad4e2 into develop Apr 14, 2026
113 of 116 checks passed
@gatesn gatesn deleted the ngates/list-view-builder branch April 14, 2026 22:54
@connortsui20
Copy link
Copy Markdown
Contributor

oh I forgot about the rebuild underneath there, without that rebuild this is incorrect but with it we dont need the scalar ats

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/performance A performance improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants