Skip to content

depreacte non compute methods without a ctx (e.g. to_canonical)#7473

Merged
joseph-isaacs merged 9 commits intodevelopfrom
ji/depreacte-non-ctx-compute
Apr 16, 2026
Merged

depreacte non compute methods without a ctx (e.g. to_canonical)#7473
joseph-isaacs merged 9 commits intodevelopfrom
ji/depreacte-non-ctx-compute

Conversation

@joseph-isaacs
Copy link
Copy Markdown
Contributor

@joseph-isaacs joseph-isaacs commented Apr 16, 2026

All access to buffer should and will require a execution context.

This PR deprecates all public methods that need one but don't have one

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs force-pushed the ji/depreacte-non-ctx-compute branch from 501a8df to 8df0d7f Compare April 16, 2026 15:02
@joseph-isaacs joseph-isaacs requested a review from gatesn April 16, 2026 15:03
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 16, 2026

Merging this PR will degrade performance by 21.65%

❌ 2 regressed benchmarks
✅ 1161 untouched benchmarks
⏩ 1457 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation varbinview_zip_block_mask 2.9 ms 3.7 ms -21.65%
Simulation varbinview_zip_fragmented_mask 6.4 ms 7.1 ms -10.51%

Comparing ji/depreacte-non-ctx-compute (5dbef40) with develop (aca6251)

Open in CodSpeed

Footnotes

  1. 1457 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs added the changelog/chore A trivial change label Apr 16, 2026
@joseph-isaacs joseph-isaacs marked this pull request as ready for review April 16, 2026 17:52
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs added changelog/deprecation A change that introduces a series of API deprecations and removed changelog/chore A trivial change labels Apr 16, 2026
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs enabled auto-merge (squash) April 16, 2026 18:33
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs merged commit d441299 into develop Apr 16, 2026
57 of 58 checks passed
@joseph-isaacs joseph-isaacs deleted the ji/depreacte-non-ctx-compute branch April 16, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/deprecation A change that introduces a series of API deprecations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants