Skip to content

break: remove try_from struct array to record batch#7488

Merged
joseph-isaacs merged 10 commits intodevelopfrom
ji/remove-try-from-record-batch
Apr 16, 2026
Merged

break: remove try_from struct array to record batch#7488
joseph-isaacs merged 10 commits intodevelopfrom
ji/remove-try-from-record-batch

Conversation

@joseph-isaacs
Copy link
Copy Markdown
Contributor

@joseph-isaacs joseph-isaacs commented Apr 16, 2026

We cannot deprecate this TryFrom so it has to be removed
Use: ArrowArrayExecutor::execute_record_batch

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
…_record_batch

Callers now derive the schema from the array dtype and use
ArrowArrayExecutor::execute_record_batch directly.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 16, 2026

Merging this PR will not alter performance

✅ 1163 untouched benchmarks
⏩ 1457 skipped benchmarks1


Comparing ji/remove-try-from-record-batch (bee8580) with develop (1b2f6ee)

Open in CodSpeed

Footnotes

  1. 1457 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
… into ji/remove-try-from-record-batch

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs changed the title Ji/remove try from record batch break: remove try_from struct array to record batch Apr 16, 2026
@joseph-isaacs joseph-isaacs added the changelog/break A breaking API change label Apr 16, 2026
@joseph-isaacs joseph-isaacs marked this pull request as ready for review April 16, 2026 17:44
@joseph-isaacs joseph-isaacs enabled auto-merge (squash) April 16, 2026 17:44
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs merged commit aca6251 into develop Apr 16, 2026
58 checks passed
@joseph-isaacs joseph-isaacs deleted the ji/remove-try-from-record-batch branch April 16, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/break A breaking API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants