Skip to content

[WIP] Re-shaping the canonical variant array to support more general …#7494

Draft
AdamGS wants to merge 8 commits intodevelopfrom
adamg/variant-array
Draft

[WIP] Re-shaping the canonical variant array to support more general …#7494
AdamGS wants to merge 8 commits intodevelopfrom
adamg/variant-array

Conversation

@AdamGS
Copy link
Copy Markdown
Contributor

@AdamGS AdamGS commented Apr 16, 2026

No description provided.

@AdamGS AdamGS force-pushed the adamg/variant-array branch 2 times, most recently from 3630cef to 5e6dd39 Compare April 16, 2026 19:06
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 16, 2026

Merging this PR will degrade performance by 21.65%

❌ 2 regressed benchmarks
✅ 1161 untouched benchmarks
⏩ 558 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation varbinview_zip_block_mask 2.9 ms 3.7 ms -21.65%
Simulation varbinview_zip_fragmented_mask 6.4 ms 7.1 ms -10.5%

Comparing adamg/variant-array (8a6a389) with develop (452a4a3)

Open in CodSpeed

Footnotes

  1. 558 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@AdamGS AdamGS force-pushed the adamg/variant-array branch from 5e6dd39 to 932cc69 Compare April 21, 2026 16:34
…forms of shredding

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS force-pushed the adamg/variant-array branch from 932cc69 to 330c582 Compare April 21, 2026 16:36
@AdamGS AdamGS added the changelog/feature A new feature label Apr 21, 2026
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS force-pushed the adamg/variant-array branch from 39510a4 to 91d1692 Compare April 21, 2026 17:02
AdamGS added 6 commits April 21, 2026 18:17
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
.
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant