Merged
Conversation
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
force-pushed
the
ct/denorm-scheme
branch
from
467ee60 to
b7cefef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tracking issue: #7297
We want to merge #7499 soon, but it is not a fair comparison because we do not normalize the uncompressed vectors flavor, but we do normalize the TurboQuant-encoded vectors. This just makes the comparison fair.
I've marked this as semi-unstable (there is no
with_turboquantequivalent on the compressor builder, but the ID is clearly unstable) just so we can get the benchmark in #7499 over the line in a reasonable state.Testing
It already works for the TurboQuant scheme, this is just a reduction of that so we don't need to test this.