Merged
Conversation
AdamGS
reviewed
Apr 17, 2026
AdamGS
reviewed
Apr 17, 2026
AdamGS
reviewed
Apr 17, 2026
Stop registering .cu/.cuh files with cargo:rerun-if-changed so that editing a CUDA kernel no longer triggers a full Rust rebuild of vortex-cuda. The build script still compiles PTX on clean builds via timestamp-based staleness checks, and uses write-if-changed for generated bit_unpack files to avoid unnecessary mtime bumps. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
0ax1
force-pushed
the
adroste/split-cuda-kernel-build
branch
from
22a8228 to
9f27745
Compare
AdamGS
approved these changes
Apr 17, 2026
0ax1
added a commit
that referenced
this pull request
Apr 17, 2026
This reverts commit 6ebb797. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
0ax1
added a commit
that referenced
this pull request
Apr 17, 2026
Needs to be reverted as CUDA changes are not properly picked up by build.rs Turns out there's no way to skip Rust build time and linkage, even if only the CUDA files changed that need to be re-generated. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, changing a .cu file triggered cargo to rerun vortex-cuda's build script, which recompiled all CUDA kernels and regenerated bindgen output, causing a full Rust recompilation. Besides skipping the Rust recompilation, we now do timestamp-based PTX compilation: Only recompile .cu files whose PTX is older than the source or any header.