Skip to content

Hack to support forcing normalization #7517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
connortsui20 merged 1 commit into from
Apr 17, 2026
+11 −0
Merged

Hack to support forcing normalization #7517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions vortex-compressor/src/compressor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ use vortex_array::arrays::list::ListArrayExt;
use vortex_array::arrays::listview::ListViewArrayExt;
use vortex_array::arrays::listview::list_from_list_view;
use vortex_array::arrays::primitive::PrimitiveArrayExt;
use vortex_array::arrays::scalar_fn::AnyScalarFn;
use vortex_array::arrays::struct_::StructArrayExt;
use vortex_array::dtype::DType;
use vortex_array::dtype::Nullability;
Expand Down Expand Up @@ -254,6 +255,11 @@ impl CascadingCompressor {
return Ok(result);
}

// TODO(connor): HACK TO SUPPORT L2 DENORMALIZATION!!!
if result.is::<AnyScalarFn>() {
return Ok(result);
}

// Otherwise, fall back to compressing the underlying storage array.
let compressed_storage = self.compress(ext_array.storage_array())?;

Expand Down Expand Up @@ -337,6 +343,11 @@ impl CascadingCompressor {
// TODO(connor): Add a tracing warning here too.
return Ok(compressed);
}

// TODO(connor): HACK TO SUPPORT L2 DENORMALIZATION!!!
if compressed.is::<AnyScalarFn>() {
return Ok(compressed);
}
}

// No scheme improved on the original.
Expand Down
Loading