avoid including experimental encoding in footer#7569
Merged
Conversation
fd51dc4 to
a40968d
Compare
Merging this PR will degrade performance by 16.63%
Performance Changes
Comparing Footnotes
|
a40968d to
51284cd
Compare
robert3005
approved these changes
Apr 20, 2026
0f89859 to
2801d63
Compare
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
853f1e0 to
94fd25f
Compare
Contributor
Author
|
I deleted the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We have been publishing a footer reference to
vortex.patchedexperimental encoding in the last few releases.The issue is that we should not be including the Patched encoding in the default array context
This removes Patched from the default array context, instead registering it conditionally where we register the other unstable encodings.
I've verified that after this change writing a file with default settings no longer includes Patched encoding