Skip to content

avoid including experimental encoding in footer#7569

Merged
a10y merged 6 commits intodevelopfrom
aduffy/array-ctx-fix
Apr 20, 2026
Merged

avoid including experimental encoding in footer#7569
a10y merged 6 commits intodevelopfrom
aduffy/array-ctx-fix

Conversation

@a10y
Copy link
Copy Markdown
Contributor

@a10y a10y commented Apr 20, 2026

Summary

We have been publishing a footer reference to vortex.patched experimental encoding in the last few releases.

The issue is that we should not be including the Patched encoding in the default array context

This removes Patched from the default array context, instead registering it conditionally where we register the other unstable encodings.

I've verified that after this change writing a file with default settings no longer includes Patched encoding

image

@a10y a10y force-pushed the aduffy/array-ctx-fix branch from fd51dc4 to a40968d Compare April 20, 2026 13:50
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 20, 2026

Merging this PR will degrade performance by 16.63%

❌ 10 regressed benchmarks
✅ 1153 untouched benchmarks
⏩ 1462 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation take_map[(0.1, 0.5)] 973 µs 1,082 µs -10.07%
Simulation take_map[(0.1, 1.0)] 1.6 ms 1.9 ms -15.11%
Simulation patched_take_10k_contiguous_not_patches 228.2 µs 258.8 µs -11.81%
Simulation patched_take_10k_contiguous_patches 227.9 µs 258.4 µs -11.83%
Simulation patched_take_10k_random 240.1 µs 270.7 µs -11.31%
Simulation take_10k_dispersed 239.7 µs 284.8 µs -15.84%
Simulation take_10k_first_chunk_only 225.8 µs 270.9 µs -16.63%
Simulation patched_take_10k_first_chunk_only 271.9 µs 302.4 µs -10.08%
Simulation decompress_rd[f64, (100000, 0.01)] 2 ms 2.3 ms -13.4%
Simulation decompress_rd[f64, (100000, 0.1)] 2 ms 2.3 ms -13.4%

Comparing aduffy/array-ctx-fix (94fd25f) with develop (f77cf60)

Open in CodSpeed

Footnotes

  1. 1462 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@a10y a10y force-pushed the aduffy/array-ctx-fix branch from a40968d to 51284cd Compare April 20, 2026 13:56
@a10y a10y added the changelog/fix A bug fix label Apr 20, 2026
@robert3005 robert3005 force-pushed the aduffy/array-ctx-fix branch from 0f89859 to 2801d63 Compare April 20, 2026 15:00
@a10y a10y enabled auto-merge (squash) April 20, 2026 15:50
a10y added 6 commits April 20, 2026 11:52
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
@a10y a10y force-pushed the aduffy/array-ctx-fix branch from 853f1e0 to 94fd25f Compare April 20, 2026 15:52
@a10y
Copy link
Copy Markdown
Contributor Author

a10y commented Apr 20, 2026

I deleted the patched.vortex compat files for now and will re-enable them once we stabilize

@a10y a10y merged commit 09601af into develop Apr 20, 2026
69 of 73 checks passed
@a10y a10y deleted the aduffy/array-ctx-fix branch April 20, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants