Skip to content

duckdb to_string: don't copy#7582

Open
myrrc wants to merge 1 commit intodevelopfrom
myrrc/duckdb-tostring
Open

duckdb to_string: don't copy#7582
myrrc wants to merge 1 commit intodevelopfrom
myrrc/duckdb-tostring

Conversation

@myrrc
Copy link
Copy Markdown
Contributor

@myrrc myrrc commented Apr 21, 2026 •
edited
Loading

  1. Don't allocate new string maps in to_string, copy to existing.
  2. Add EXPLAIN test for to_string
  3. Fix a bug in duckdb sql logic tests runner which didn't compare JSON correctly.

@myrrc
duckdb to_string: don't copy
e4d1119 
Signed-off-by: Mikhail Kot <to@myrrc.dev>
@myrrc myrrc requested a review from 0ax1 April 21, 2026 10:01
@myrrc myrrc added the changelog/chore A trivial change label Apr 21, 2026
@myrrc myrrc enabled auto-merge (squash) April 21, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0ax1 0ax1 Awaiting requested review from 0ax1

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

changelog/chore A trivial change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@myrrc