Make StatsCache and ArrayAndStats have interior mutability#7583
Merged
connortsui20 merged 1 commit intodevelopfrom Apr 21, 2026
Merged
Make StatsCache and ArrayAndStats have interior mutability#7583connortsui20 merged 1 commit intodevelopfrom
StatsCache and ArrayAndStats have interior mutability#7583connortsui20 merged 1 commit intodevelopfrom
Conversation
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
robert3005
approved these changes
Apr 21, 2026
Contributor
|
Wait, why is this better? isn't it preferable to not have extra unnecessary locking? |
Contributor
Author
|
@a10y The fastpath on the mutex will basically never lock because the compressor only runs single-threaded, the only reason is to keep this |
Contributor
|
I don't think this affects the Sendness of the compressor schemes? |
Contributor
Author
|
Sorry, to keep the array and stats sync |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tracking issue: #7216
It was unfortunate that
ArrayAndStatshad to be taken by&mut, so this change makes updates use interior mutability.API Changes
SchemetakesArrayAndStatsby shared reference instead of by exclusive reference.Testing
N/A since there isn't any semantic change here, just API changes.