Extend DType::least_supertype to cover FixedSizeList, List, and tensor extensions#7596
Merged
Extend DType::least_supertype to cover FixedSizeList, List, and tensor extensions#7596
Conversation
connortsui20
requested changes
Apr 22, 2026
palaska
force-pushed
the
bp/least-supertype
branch
from
1ffa0c4 to
1bf1744
Compare
connortsui20
approved these changes
Apr 22, 2026
Contributor
connortsui20
left a comment
connortsui20
left a comment
There was a problem hiding this comment.
Nit: Ordering of numbers in the comments is off, but otherwise LGTM!
Signed-off-by: Baris Palaska <barispalaska@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Widening Vector<f32, 768> and Vector<f64, 768> now returns Vector<f64, 768> instead of None.