Skip to content

remove unused methods from duckdb vtab#7602

Merged
myrrc merged 1 commit intodevelopfrom
myrrc/duckdb-smaller-vtab
Apr 23, 2026
Merged

remove unused methods from duckdb vtab#7602
myrrc merged 1 commit intodevelopfrom
myrrc/duckdb-smaller-vtab

Conversation

@myrrc
Copy link
Copy Markdown
Contributor

@myrrc myrrc commented Apr 23, 2026

  1. Remove unused and not set methods from duckdb vtab.
  2. Correctly set MAX_THREADS for table function (was u64::MAX but duckdb uses
    another constant).
  3. Move boolean definitions like filter pushdown to C++ part.
  4. Remove named parameters since we don't support them.
  5. Fix a memory leak when throwing errors.

@myrrc myrrc requested a review from 0ax1 April 23, 2026 10:39
@myrrc myrrc added the changelog/chore A trivial change label Apr 23, 2026
Signed-off-by: Mikhail Kot <to@myrrc.dev>
@myrrc myrrc force-pushed the myrrc/duckdb-smaller-vtab branch from ac67472 to b3eb6a4 Compare April 23, 2026 10:40
@myrrc myrrc enabled auto-merge (squash) April 23, 2026 10:42
@myrrc myrrc merged commit 2167e61 into develop Apr 23, 2026
58 of 59 checks passed
@myrrc myrrc deleted the myrrc/duckdb-smaller-vtab branch April 23, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants