Merged
Conversation
Signed-off-by: Mikhail Kot <to@myrrc.dev>
myrrc
force-pushed
the
myrrc/deadlock-session
branch
from
796a903 to
9e2dbdc
Compare
AdamGS
approved these changes
Apr 23, 2026
Contributor
AdamGS
left a comment
AdamGS
left a comment
There was a problem hiding this comment.
LGTM, we should probably consider doing this for more values? VortexSession is probably very easy to deadlock this way
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Querying allows_unknown + allow_unknown leads to a deadlock in FFI tests.