Skip to content

Clean up vortex-tensor even more#7610

Merged
connortsui20 merged 2 commits intodevelopfrom
ct/cleanup-tensor-more
Apr 23, 2026
Merged

Clean up vortex-tensor even more#7610
connortsui20 merged 2 commits intodevelopfrom
ct/cleanup-tensor-more

Conversation

@connortsui20
Copy link
Copy Markdown
Contributor

Summary

Tracking issue: #7297

This is mostly just cosmetic changes that will help with some future changes incoming.

  • Extract validate_vector_storage_dtype from Vector::validate_dtype into types/vector/mod.rs.
  • Move unit_norm_tolerance and BinaryTensorOpMetadata into utils.rs; switch unit_norm_tolerance to the c*sqrt(d)*epsilon bound with a dimensions parameter.
  • Drop op_name from validate_binary_tensor_float_inputs.
  • TurboQuantConfig::seed Option -> u64.
  • SorfOptions::dimension -> SorfOptions::dimensions and matching SorfMatrix::try_new parameter.
  • centroids::get_centroids -> compute_or_get_centroids.
  • Crate-root #![cfg_attr(test, allow(clippy::unwrap_used, clippy::expect_used, clippy::unwrap_in_result))].
  • Extract validate_vector_storage_dtype from Vector::validate_dtype into types/vector/mod.rs.
  • Move unit_norm_tolerance and BinaryTensorOpMetadata into utils.rs; switch unit_norm_tolerance to the c*sqrt(d)*epsilon bound with a dimensions parameter.
  • Drop op_name from validate_binary_tensor_float_inputs.
  • TurboQuantConfig::seed Option -> u64.
  • SorfOptions::dimension -> SorfOptions::dimensions and matching SorfMatrix::try_new parameter.
  • centroids::get_centroids -> compute_or_get_centroids.
  • Crate-root #![cfg_attr(test, allow(clippy::unwrap_used, clippy::expect_used, clippy::unwrap_in_result))].

API Changes

Some renames

Testing

N/A

@connortsui20 connortsui20 added the changelog/chore A trivial change label Apr 23, 2026
@connortsui20 connortsui20 enabled auto-merge (squash) April 23, 2026 14:53
…dimensions

- Extract validate_vector_storage_dtype from Vector::validate_dtype into
  types/vector/mod.rs.
- Move unit_norm_tolerance and BinaryTensorOpMetadata into utils.rs; switch
  unit_norm_tolerance to the c*sqrt(d)*epsilon bound with a dimensions parameter.
- Drop op_name from validate_binary_tensor_float_inputs.
- TurboQuantConfig::seed Option<u64> -> u64.
- SorfOptions::dimension -> SorfOptions::dimensions and matching SorfMatrix::try_new
  parameter.
- centroids::get_centroids -> compute_or_get_centroids.
- Crate-root #![cfg_attr(test, allow(clippy::unwrap_used, clippy::expect_used,
  clippy::unwrap_in_result))].

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 force-pushed the ct/cleanup-tensor-more branch from fad778e to 28f7ce0 Compare April 23, 2026 15:20
@connortsui20 connortsui20 merged commit b6ee27b into develop Apr 23, 2026
58 of 59 checks passed
@connortsui20 connortsui20 deleted the ct/cleanup-tensor-more branch April 23, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants