Clean up vortex-tensor even more#7610
Merged
connortsui20 merged 2 commits intodevelopfrom Apr 23, 2026
Merged
Conversation
42 tasks
robert3005
approved these changes
Apr 23, 2026
…dimensions - Extract validate_vector_storage_dtype from Vector::validate_dtype into types/vector/mod.rs. - Move unit_norm_tolerance and BinaryTensorOpMetadata into utils.rs; switch unit_norm_tolerance to the c*sqrt(d)*epsilon bound with a dimensions parameter. - Drop op_name from validate_binary_tensor_float_inputs. - TurboQuantConfig::seed Option<u64> -> u64. - SorfOptions::dimension -> SorfOptions::dimensions and matching SorfMatrix::try_new parameter. - centroids::get_centroids -> compute_or_get_centroids. - Crate-root #![cfg_attr(test, allow(clippy::unwrap_used, clippy::expect_used, clippy::unwrap_in_result))]. Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
fad778e to
28f7ce0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tracking issue: #7297
This is mostly just cosmetic changes that will help with some future changes incoming.
API Changes
Some renames
Testing
N/A