duckdb: don't copy vtab on function bind#7616
Merged
Conversation
myrrc
force-pushed
the
myrrc/duckdb-chore-2
branch
from
b83881f to
6b36816
Compare
myrrc
force-pushed
the
myrrc/duckdb-chore-2
branch
from
6b36816 to
cdf012d
Compare
robert3005
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store a reference to function's info in bind data to avoid copying vtab.
Derive bind data from base class and not derived one to save a few bytes.
Replace a few nullptr returns with D_ASSERTs.