Fix dtype mismatch in FileStatsLayoutReader for stat scalars#7639
Open
brainhart wants to merge 1 commit intovortex-data:developfrom
Open
Fix dtype mismatch in FileStatsLayoutReader for stat scalars#7639brainhart wants to merge 1 commit intovortex-data:developfrom
brainhart wants to merge 1 commit intovortex-data:developfrom
Conversation
Use the stat's own dtype (e.g. u64 for NullCount) rather than the field dtype when constructing stat scalars in stats_ref. This fixes IS NULL pruning on nullable timestamp columns which previously failed with a dtype mismatch. Add regression test for is_null pruning on a nullable timestamp column. Signed-off-by: Brian Hart <brian@brainhart.dev>
brainhart
force-pushed
the
fix-stat-dtype-mismatch
branch
from
f9b3546 to
889b25f
Compare
robert3005
approved these changes
Apr 26, 2026
Contributor
robert3005
left a comment
robert3005
left a comment
There was a problem hiding this comment.
I have also seen this in #7589
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the stat's own dtype (e.g. u64 for NullCount) rather than the field dtype when constructing stat scalars in stats_ref. This fixes IS NULL pruning on nullable timestamp columns which previously failed with a dtype mismatch.
Testing
Added regression test