Rename ScalarValue::List to ScalarValue::Tuple#7672
Merged
connortsui20 merged 1 commit intodevelopfrom Apr 27, 2026
Merged
Conversation
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Merging this PR will degrade performance by 23.9%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | old_alp_prim_test_between[f64, 16384] |
189.5 µs | 212.9 µs | -11.01% |
| ❌ | Simulation | old_bp_prim_test_between[i32, 32768] |
203.2 µs | 233.1 µs | -12.83% |
| ❌ | Simulation | old_bp_prim_test_between[i64, 16384] |
172 µs | 203.3 µs | -15.38% |
| ❌ | Simulation | new_alp_prim_test_between[f64, 32768] |
191.4 µs | 235.1 µs | -18.6% |
| ❌ | Simulation | new_bp_prim_test_between[i32, 32768] |
140.3 µs | 169 µs | -17.03% |
| ❌ | Simulation | new_alp_prim_test_between[f32, 32768] |
139 µs | 182.7 µs | -23.9% |
| ❌ | Simulation | new_alp_prim_test_between[f64, 16384] |
125.6 µs | 147.4 µs | -14.77% |
Comparing ct/sv-tuple (ea8d0f0) with develop (e75c62c)
gatesn
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a better name for what it actually is, where every value can have a different type. And given that we want
ScalarValue::Arrayfor list scalars soon this makes more sense.API Changes
Renames the variant.
Testing
N/A since this is a rename.