Skip to content

Rename ScalarValue::List to ScalarValue::Tuple#7672

Merged
connortsui20 merged 1 commit intodevelopfrom
ct/sv-tuple
Apr 27, 2026
Merged

Rename ScalarValue::List to ScalarValue::Tuple#7672
connortsui20 merged 1 commit intodevelopfrom
ct/sv-tuple

Conversation

@connortsui20
Copy link
Copy Markdown
Contributor

Summary

This is a better name for what it actually is, where every value can have a different type. And given that we want ScalarValue::Array for list scalars soon this makes more sense.

API Changes

Renames the variant.

Testing

N/A since this is a rename.

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 added the changelog/chore A trivial change label Apr 27, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 27, 2026

Merging this PR will degrade performance by 23.9%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 7 regressed benchmarks
✅ 1156 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation old_alp_prim_test_between[f64, 16384] 189.5 µs 212.9 µs -11.01%
Simulation old_bp_prim_test_between[i32, 32768] 203.2 µs 233.1 µs -12.83%
Simulation old_bp_prim_test_between[i64, 16384] 172 µs 203.3 µs -15.38%
Simulation new_alp_prim_test_between[f64, 32768] 191.4 µs 235.1 µs -18.6%
Simulation new_bp_prim_test_between[i32, 32768] 140.3 µs 169 µs -17.03%
Simulation new_alp_prim_test_between[f32, 32768] 139 µs 182.7 µs -23.9%
Simulation new_alp_prim_test_between[f64, 16384] 125.6 µs 147.4 µs -14.77%

Comparing ct/sv-tuple (ea8d0f0) with develop (e75c62c)

Open in CodSpeed

@connortsui20 connortsui20 merged commit 85e95fc into develop Apr 27, 2026
66 of 68 checks passed
@connortsui20 connortsui20 deleted the ct/sv-tuple branch April 27, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants