Skip to content

make all scalar view types Copy#7673

Merged
connortsui20 merged 1 commit intodevelopfrom
ct/scalar-views-copy
Apr 27, 2026
Merged

make all scalar view types Copy#7673
connortsui20 merged 1 commit intodevelopfrom
ct/scalar-views-copy

Conversation

@connortsui20
Copy link
Copy Markdown
Contributor

Summary

Closes: #4844

API Changes

Adds Copy impl for all scalar view types.

Testing

N/A

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 requested review from a10y and robert3005 April 27, 2026 15:39
@connortsui20 connortsui20 added the changelog/skip Do not list PR in the changelog label Apr 27, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 27, 2026

Merging this PR will degrade performance by 24.04%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 7 regressed benchmarks
✅ 1156 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation new_bp_prim_test_between[i32, 32768] 140.3 µs 169.3 µs -17.14%
Simulation new_alp_prim_test_between[f64, 32768] 191.4 µs 235.3 µs -18.65%
Simulation old_bp_prim_test_between[i64, 16384] 172 µs 203.5 µs -15.45%
Simulation old_alp_prim_test_between[f64, 16384] 189.5 µs 213.1 µs -11.08%
Simulation old_bp_prim_test_between[i32, 32768] 203.2 µs 233.5 µs -12.96%
Simulation new_alp_prim_test_between[f32, 32768] 139 µs 183.1 µs -24.04%
Simulation new_alp_prim_test_between[f64, 16384] 125.6 µs 147.6 µs -14.86%

Comparing ct/scalar-views-copy (a66cb93) with develop (e75c62c)

Open in CodSpeed

@connortsui20 connortsui20 merged commit 27b1825 into develop Apr 27, 2026
70 of 72 checks passed
@connortsui20 connortsui20 deleted the ct/scalar-views-copy branch April 27, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/skip Do not list PR in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make all _Scalar types Clone and Copy

3 participants