Validity casting doesn't hide usage of execution context#7710
Draft
robert3005 wants to merge 1 commit intodevelopfrom
Draft
Validity casting doesn't hide usage of execution context#7710robert3005 wants to merge 1 commit intodevelopfrom
robert3005 wants to merge 1 commit intodevelopfrom
Conversation
Signed-off-by: Robert Kruszewski <github@robertk.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Casting validity correctly advertises that it might do compute by requiring
context.
We split the logic of casting between CastReduce rules which can handle all
NonNullalbe -> Nullable and Nullable -> NonNullable casts if stats have been
calculated and CastKernels which need to handle full generality of casts, in
practice Nullable to NonNullable casts
Signed-off-by: Robert Kruszewski github@robertk.io