Revert "Late materialization support for duckdb"#7719
Merged
joseph-isaacs merged 1 commit intodevelopfrom Apr 29, 2026
Merged
Conversation
This reverts commit ea75e28.
joseph-isaacs
commented
Apr 29, 2026
Comment on lines
-128
to
-131
| /// If we're operating on files, what files to read | ||
| pub file_selection: Selection, | ||
| /// If we're operating on files, what files to read | ||
| pub file_range: Option<Range<u64>>, |
Contributor
Author
There was a problem hiding this comment.
Its this I want to refine further
Merging this PR will improve performance by 11.85%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[128] |
275.3 ns | 246.1 ns | +11.85% |
Comparing revert-7631-myrrc/duckdb-row-id-columns (efd6103) with develop (ea75e28)
Footnotes
-
33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
myrrc
approved these changes
Apr 29, 2026
robert3005
pushed a commit
that referenced
this pull request
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #7631