Skip to content

skip: remove parameter names from public api lock files#7728

Open
joseph-isaacs wants to merge 5 commits intodevelopfrom
ji/remove-param-names-public-lock
Open

skip: remove parameter names from public api lock files#7728
joseph-isaacs wants to merge 5 commits intodevelopfrom
ji/remove-param-names-public-lock

Conversation

@joseph-isaacs
Copy link
Copy Markdown
Contributor

The names should append the public api signature.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
…mes-public-lock

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

# Conflicts:
#	vortex-array/public-api.lock
u
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs added the changelog/skip Do not list PR in the changelog label Apr 30, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 30, 2026

Merging this PR will degrade performance by 34.32%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
❌ 1 regressed benchmark
✅ 1195 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime dynamic_dispatch_u32[10M] 113.7 µs 173.1 µs -34.32%
WallTime 10M_50%[5000000] 308.6 µs 276.5 µs +11.61%
WallTime decompress_kernel[1M] 423.9 µs 378.9 µs +11.89%

Comparing ji/remove-param-names-public-lock (b5a043c) with develop (e8c4ae9)

Open in CodSpeed

@joseph-isaacs joseph-isaacs marked this pull request as ready for review April 30, 2026 12:20
u
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@AdamGS
Copy link
Copy Markdown
Contributor

AdamGS commented Apr 30, 2026

can we just remove them? I don't think we actually look at them, and we don't use them to actually communicate API changes in the changelog/release notes.

u
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs
Copy link
Copy Markdown
Contributor Author

I agree with this, do we have a plan to make these useful? @robert3005 @gatesn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/skip Do not list PR in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants