skip: remove parameter names from public api lock files#7728
skip: remove parameter names from public api lock files#7728joseph-isaacs wants to merge 5 commits intodevelopfrom
Conversation
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
…mes-public-lock Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> # Conflicts: # vortex-array/public-api.lock
Merging this PR will degrade performance by 34.32%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | WallTime | dynamic_dispatch_u32[10M] |
113.7 µs | 173.1 µs | -34.32% |
| ⚡ | WallTime | 10M_50%[5000000] |
308.6 µs | 276.5 µs | +11.61% |
| ⚡ | WallTime | decompress_kernel[1M] |
423.9 µs | 378.9 µs | +11.89% |
Comparing ji/remove-param-names-public-lock (b5a043c) with develop (e8c4ae9)
|
can we just remove them? I don't think we actually look at them, and we don't use them to actually communicate API changes in the changelog/release notes. |
|
I agree with this, do we have a plan to make these useful? @robert3005 @gatesn |
The names should append the public api signature.