Fix weird signature of with_slots functions#7758
Conversation
Signed-off-by: Robert Kruszewski <github@robertk.io>
Merging this PR will degrade performance by 25.02%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | new_bp_prim_test_between[i64, 32768] |
177.3 µs | 236.5 µs | -25.02% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[128] |
275.3 ns | 246.1 ns | +11.85% |
Comparing rk/signature (10a45d4) with develop (5e5572b)
Footnotes
-
138 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
with_slots doesn't need to pass the original ref to the arrayinner methods as
unique ownership arc is handled earlier
Signed-off-by: Robert Kruszewski github@robertk.io