Fix table output for random access benchmark#7806
Conversation
Signed-off-by: Robert Kruszewski <github@robertk.io>
Merging this PR will improve performance by 17.09%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | WallTime | cuda/bitpacked_u8/unpack/3bw[100M] |
352.7 µs | 301.2 µs | +17.09% |
Comparing rk/fixrandomaccessbench (72a0785) with develop (924409f)
|
|
||
| match display_format { | ||
| DisplayFormat::Table => { | ||
| render_table(&mut writer, measurements, &targets)?; |
There was a problem hiding this comment.
The trouble is here. Even though targets now only has Vortex, Vortex, Arrow, Parquet, and Arrow, Lance, you're sending in way more measurements. Which value is displayed for Dataset A and Vortex, Vortex? The NVME & footer? non-NVME & footer? NVME & non-footer? non-NVME & non-footer?
The Target is not rich enough to capture all the possible ways in which a benchmark is indexed.
There was a problem hiding this comment.
Interesting that it continues to display fine for json output. I have made them produce display from the source of data originally and looks like this got broken
2 participants
Signed-off-by: Robert Kruszewski github@robertk.io