Skip to content

fix[array]: get_item reduce + struct wrong nullability#7887

Merged
joseph-isaacs merged 1 commit into
developfrom
ji/like-get-item-get
May 11, 2026
Merged

fix[array]: get_item reduce + struct wrong nullability#7887
joseph-isaacs merged 1 commit into
developfrom
ji/like-get-item-get

Conversation

@joseph-isaacs
Copy link
Copy Markdown
Contributor

@joseph-isaacs joseph-isaacs commented May 11, 2026

fixes: #7878

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs marked this pull request as ready for review May 11, 2026 16:16
@joseph-isaacs joseph-isaacs requested a review from robert3005 May 11, 2026 16:16
Copy link
Copy Markdown
Contributor

@robert3005 robert3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here I thought this is more complicated

@robert3005 robert3005 added the changelog/fix A bug fix label May 11, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 11, 2026

Merging this PR will improve performance by 19.48%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 9 improved benchmarks
✅ 1201 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation encode_varbin[(1000, 2)] 167.7 µs 146.6 µs +14.42%
Simulation encode_varbin[(1000, 32)] 169.6 µs 153 µs +10.83%
Simulation encode_varbin[(1000, 4)] 163.7 µs 147.2 µs +11.27%
Simulation encode_varbin[(1000, 8)] 164.5 µs 147.9 µs +11.17%
Simulation patched_take_10k_dispersed 317.9 µs 288.1 µs +10.36%
Simulation patched_take_10k_first_chunk_only 304.2 µs 274.4 µs +10.89%
Simulation patched_take_10k_adversarial 260.8 µs 230.9 µs +12.98%
Simulation take_10k_first_chunk_only 272.6 µs 228.2 µs +19.48%
Simulation take_10k_dispersed 286.3 µs 241.8 µs +18.4%

Comparing ji/like-get-item-get (38efa22) with develop (93d0b4e)

Open in CodSpeed

@joseph-isaacs joseph-isaacs merged commit af7839a into develop May 11, 2026
70 of 71 checks passed
@joseph-isaacs joseph-isaacs deleted the ji/like-get-item-get branch May 11, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

apply() nullability bug

2 participants