Update flatbuffers generated#7899
Conversation
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
|
This is because of google/flatbuffers#8564 and google/flatbuffers#8828 which is somewhat recent |
|
You have to update versions used by CI as well |
Merging this PR will improve performance by 32.84%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | new_bp_prim_test_between[i64, 16384] |
144.9 µs | 115.7 µs | +25.28% |
| ⚡ | Simulation | new_bp_prim_test_between[i16, 32768] |
134.8 µs | 120.9 µs | +11.46% |
| ⚡ | Simulation | new_bp_prim_test_between[i32, 32768] |
170.3 µs | 141.5 µs | +20.36% |
| ⚡ | Simulation | new_bp_prim_test_between[i64, 32768] |
237.2 µs | 178.6 µs | +32.84% |
| ⚡ | Simulation | new_bp_prim_test_between[i32, 16384] |
109.4 µs | 95.1 µs | +15% |
| ⚡ | Simulation | new_alp_prim_test_between[f64, 16384] |
149.4 µs | 127.6 µs | +17.1% |
Comparing ct/fb-update (ceeeaed) with develop (6f54d3d)
| flatc_version: | ||
| description: "Version of the flatc binary" | ||
| default: "25.9.23" | ||
| default: "25.12.19" |
There was a problem hiding this comment.
this doesn't get run on our ami images, you will have to update them and then make a pr. Annoyingly there will be an amount of time when all prs will fail because of it :/
There was a problem hiding this comment.
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
55d296e to
ceeeaed
Compare
|
Do I need to rerun this: https://github.com/vortex-data/.github-private/actions/runs/25746194678/job/75609981444 |
Summary
I am not sure why but my local flatc produces different results than CI. Do we need to update something?
This happens on both my linux machine and mac.
Testing
N/A