Skip to content

Update flatbuffers generated#7899

Merged
connortsui20 merged 2 commits into
developfrom
ct/fb-update
May 12, 2026
Merged

Update flatbuffers generated#7899
connortsui20 merged 2 commits into
developfrom
ct/fb-update

Conversation

@connortsui20
Copy link
Copy Markdown
Contributor

@connortsui20 connortsui20 commented May 12, 2026

Summary

I am not sure why but my local flatc produces different results than CI. Do we need to update something?

This happens on both my linux machine and mac.

❯ flatc --version
flatc version 25.12.19

Testing

N/A

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20
Copy link
Copy Markdown
Contributor Author

connortsui20 commented May 12, 2026

This is because of google/flatbuffers#8564 and google/flatbuffers#8828 which is somewhat recent

@robert3005
Copy link
Copy Markdown
Contributor

You have to update versions used by CI as well

@connortsui20 connortsui20 marked this pull request as ready for review May 12, 2026 14:54
@connortsui20 connortsui20 enabled auto-merge (squash) May 12, 2026 14:54
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 12, 2026

Merging this PR will improve performance by 32.84%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 6 improved benchmarks
✅ 1204 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation new_bp_prim_test_between[i64, 16384] 144.9 µs 115.7 µs +25.28%
Simulation new_bp_prim_test_between[i16, 32768] 134.8 µs 120.9 µs +11.46%
Simulation new_bp_prim_test_between[i32, 32768] 170.3 µs 141.5 µs +20.36%
Simulation new_bp_prim_test_between[i64, 32768] 237.2 µs 178.6 µs +32.84%
Simulation new_bp_prim_test_between[i32, 16384] 109.4 µs 95.1 µs +15%
Simulation new_alp_prim_test_between[f64, 16384] 149.4 µs 127.6 µs +17.1%

Comparing ct/fb-update (ceeeaed) with develop (6f54d3d)

Open in CodSpeed

flatc_version:
description: "Version of the flatc binary"
default: "25.9.23"
default: "25.12.19"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't get run on our ami images, you will have to update them and then make a pr. Annoyingly there will be an amount of time when all prs will fail because of it :/

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20
Copy link
Copy Markdown
Contributor Author

@connortsui20 connortsui20 merged commit c663fa9 into develop May 12, 2026
62 checks passed
@connortsui20 connortsui20 deleted the ct/fb-update branch May 12, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants