Conversation
robert3005
reviewed
Sep 11, 2024
Comment on lines
+95
to
+96
| let l_is_const = ConstantArray::try_from(left).is_ok()|| left.statistics().get_as::<bool>(Stat::IsConstant).unwrap_or_default(); | ||
| let r_is_const = ConstantArray::try_from(right).is_ok()|| right.statistics().get_as::<bool>(Stat::IsConstant).unwrap_or_default(); |
Contributor
There was a problem hiding this comment.
might be easier to compare encoding ids?
Contributor
Author
There was a problem hiding this comment.
That's what I did a few PRs ago and someone steered me towards try_from, but I agree
github-actions
Bot
removed
the
action/benchmark
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Vortex benchmarks
Details
| Benchmark suite | Current: e722385 | Previous: d1ec381 | Ratio |
|---|---|---|---|
tpch_q1/vortex-in-memory-no-pushdown |
459006289 ns/iter (± 4082096) |
460316744 ns/iter (± 2507747) |
1.00 |
tpch_q1/vortex-in-memory-pushdown |
516095098 ns/iter (± 5163858) |
513722664 ns/iter (± 5123848) |
1.00 |
tpch_q1/arrow |
445241789 ns/iter (± 2132704) |
448215677 ns/iter (± 2526475) |
0.99 |
tpch_q1/parquet |
647806883 ns/iter (± 9171617) |
652939792 ns/iter (± 1688085) |
0.99 |
tpch_q1/vortex-file-compressed |
603817002 ns/iter (± 7072505) |
603324062 ns/iter (± 13780783) |
1.00 |
tpch_q1/vortex-file-uncompressed |
552433429 ns/iter (± 1559917) |
552995533 ns/iter (± 1273803) |
1.00 |
tpch_q2/vortex-in-memory-no-pushdown |
138934258 ns/iter (± 1051691) |
138353616 ns/iter (± 353941) |
1.00 |
tpch_q2/vortex-in-memory-pushdown |
138457994 ns/iter (± 1701833) |
139212032 ns/iter (± 504737) |
0.99 |
tpch_q2/arrow |
121581076 ns/iter (± 287012) |
120716543 ns/iter (± 287361) |
1.01 |
tpch_q2/parquet |
155323478 ns/iter (± 496694) |
153816077 ns/iter (± 742337) |
1.01 |
tpch_q2/vortex-file-compressed |
153388163 ns/iter (± 637697) |
155500449 ns/iter (± 429216) |
0.99 |
tpch_q2/vortex-file-uncompressed |
159143983 ns/iter (± 1341146) |
158782291 ns/iter (± 846313) |
1.00 |
tpch_q3/vortex-in-memory-no-pushdown |
149857592 ns/iter (± 719320) |
148249178 ns/iter (± 620444) |
1.01 |
tpch_q3/vortex-in-memory-pushdown |
182617936 ns/iter (± 3551028) |
175568561 ns/iter (± 536448) |
1.04 |
tpch_q3/arrow |
144531959 ns/iter (± 933615) |
143519137 ns/iter (± 301294) |
1.01 |
tpch_q3/parquet |
332037480 ns/iter (± 1107374) |
328251864 ns/iter (± 581724) |
1.01 |
tpch_q3/vortex-file-compressed |
218230770 ns/iter (± 882794) |
215559906 ns/iter (± 1042076) |
1.01 |
tpch_q3/vortex-file-uncompressed |
244603036 ns/iter (± 3808941) |
241251438 ns/iter (± 3905688) |
1.01 |
tpch_q4/vortex-in-memory-no-pushdown |
114164292 ns/iter (± 321170) |
113549206 ns/iter (± 624387) |
1.01 |
tpch_q4/vortex-in-memory-pushdown |
135666625 ns/iter (± 715337) |
133723287 ns/iter (± 447116) |
1.01 |
tpch_q4/arrow |
109866804 ns/iter (± 785391) |
110318590 ns/iter (± 249777) |
1.00 |
tpch_q4/parquet |
220211614 ns/iter (± 624899) |
219123233 ns/iter (± 878784) |
1.00 |
tpch_q4/vortex-file-compressed |
200919182 ns/iter (± 2127831) |
201479394 ns/iter (± 1018436) |
1.00 |
tpch_q4/vortex-file-uncompressed |
207135698 ns/iter (± 2794650) |
211002664 ns/iter (± 1135213) |
0.98 |
tpch_q5/vortex-in-memory-no-pushdown |
287291917 ns/iter (± 2594565) |
280413831 ns/iter (± 5426441) |
1.02 |
tpch_q5/vortex-in-memory-pushdown |
298645920 ns/iter (± 988107) |
289657335 ns/iter (± 2203139) |
1.03 |
tpch_q5/arrow |
282429350 ns/iter (± 2269462) |
280555368 ns/iter (± 1709117) |
1.01 |
tpch_q5/parquet |
435453911 ns/iter (± 1011442) |
428966406 ns/iter (± 1198255) |
1.02 |
tpch_q5/vortex-file-compressed |
323300658 ns/iter (± 2459347) |
319460128 ns/iter (± 4640222) |
1.01 |
tpch_q5/vortex-file-uncompressed |
333161529 ns/iter (± 2285747) |
333861681 ns/iter (± 4363968) |
1.00 |
tpch_q6/vortex-in-memory-no-pushdown |
39937706 ns/iter (± 226646) |
39700021 ns/iter (± 80678) |
1.01 |
tpch_q6/vortex-in-memory-pushdown |
98620996 ns/iter (± 335475) |
88463868 ns/iter (± 198151) |
1.11 |
tpch_q6/arrow |
35809722 ns/iter (± 620600) |
36213528 ns/iter (± 165820) |
0.99 |
tpch_q6/parquet |
151377942 ns/iter (± 2764171) |
151039477 ns/iter (± 697342) |
1.00 |
tpch_q6/vortex-file-compressed |
79921318 ns/iter (± 560578) |
77599073 ns/iter (± 489840) |
1.03 |
tpch_q6/vortex-file-uncompressed |
165573367 ns/iter (± 1145805) |
153822678 ns/iter (± 1630428) |
1.08 |
tpch_q7/vortex-in-memory-no-pushdown |
550643388 ns/iter (± 4109395) |
554725014 ns/iter (± 2247267) |
0.99 |
tpch_q7/vortex-in-memory-pushdown |
601121936 ns/iter (± 4004447) |
602405633 ns/iter (± 1374727) |
1.00 |
tpch_q7/arrow |
542518531 ns/iter (± 3099217) |
541369046 ns/iter (± 834831) |
1.00 |
tpch_q7/parquet |
701286104 ns/iter (± 17593971) |
696305261 ns/iter (± 3099214) |
1.01 |
tpch_q7/vortex-file-compressed |
636710638 ns/iter (± 3694069) |
633896764 ns/iter (± 2836098) |
1.00 |
tpch_q7/vortex-file-uncompressed |
661571933 ns/iter (± 3919213) |
655092604 ns/iter (± 2532606) |
1.01 |
tpch_q8/vortex-in-memory-no-pushdown |
210527635 ns/iter (± 276064) |
212597330 ns/iter (± 2163597) |
0.99 |
tpch_q8/vortex-in-memory-pushdown |
220557543 ns/iter (± 1836017) |
216297590 ns/iter (± 862823) |
1.02 |
tpch_q8/arrow |
204822091 ns/iter (± 368219) |
203486003 ns/iter (± 1049182) |
1.01 |
tpch_q8/parquet |
468960300 ns/iter (± 874156) |
467185817 ns/iter (± 2702777) |
1.00 |
tpch_q8/vortex-file-compressed |
248848157 ns/iter (± 1165393) |
247397537 ns/iter (± 7994068) |
1.01 |
tpch_q8/vortex-file-uncompressed |
273865351 ns/iter (± 957848) |
281705089 ns/iter (± 2640745) |
0.97 |
tpch_q9/vortex-in-memory-no-pushdown |
390503298 ns/iter (± 3945526) |
396311379 ns/iter (± 1090016) |
0.99 |
tpch_q9/vortex-in-memory-pushdown |
390847412 ns/iter (± 1079154) |
391470958 ns/iter (± 2679387) |
1.00 |
tpch_q9/arrow |
384966930 ns/iter (± 1132422) |
386092021 ns/iter (± 3757182) |
1.00 |
tpch_q9/parquet |
682280754 ns/iter (± 2211922) |
677584132 ns/iter (± 4314860) |
1.01 |
tpch_q9/vortex-file-compressed |
415317416 ns/iter (± 5283868) |
432492795 ns/iter (± 1938476) |
0.96 |
tpch_q9/vortex-file-uncompressed |
453311987 ns/iter (± 2189937) |
460195745 ns/iter (± 8641905) |
0.99 |
tpch_q10/vortex-in-memory-no-pushdown |
230615622 ns/iter (± 735659) |
232664317 ns/iter (± 437267) |
0.99 |
tpch_q10/vortex-in-memory-pushdown |
257469197 ns/iter (± 1076554) |
253263332 ns/iter (± 863513) |
1.02 |
tpch_q10/arrow |
222586840 ns/iter (± 816622) |
225905211 ns/iter (± 694284) |
0.99 |
tpch_q10/parquet |
478015474 ns/iter (± 4024415) |
477878131 ns/iter (± 689045) |
1.00 |
tpch_q10/vortex-file-compressed |
428828331 ns/iter (± 3756564) |
427215496 ns/iter (± 1356763) |
1.00 |
tpch_q10/vortex-file-uncompressed |
335910924 ns/iter (± 3479038) |
331263815 ns/iter (± 1532896) |
1.01 |
tpch_q11/vortex-in-memory-no-pushdown |
216226125 ns/iter (± 988479) |
215523640 ns/iter (± 637265) |
1.00 |
tpch_q11/vortex-in-memory-pushdown |
217255636 ns/iter (± 1542809) |
214262929 ns/iter (± 572788) |
1.01 |
tpch_q11/arrow |
178157347 ns/iter (± 1733553) |
172484928 ns/iter (± 438723) |
1.03 |
tpch_q11/parquet |
186077784 ns/iter (± 838353) |
179694536 ns/iter (± 555140) |
1.04 |
tpch_q11/vortex-file-compressed |
224280276 ns/iter (± 1101473) |
222709774 ns/iter (± 773894) |
1.01 |
tpch_q11/vortex-file-uncompressed |
227461329 ns/iter (± 2968256) |
228708854 ns/iter (± 1539715) |
0.99 |
tpch_q12/vortex-in-memory-no-pushdown |
182059129 ns/iter (± 681465) |
176488836 ns/iter (± 155883) |
1.03 |
tpch_q12/vortex-in-memory-pushdown |
256175879 ns/iter (± 927285) |
247026498 ns/iter (± 210674) |
1.04 |
tpch_q12/arrow |
171403876 ns/iter (± 404306) |
166734947 ns/iter (± 256968) |
1.03 |
tpch_q12/parquet |
355353774 ns/iter (± 850333) |
351355349 ns/iter (± 713799) |
1.01 |
tpch_q12/vortex-file-compressed |
578362314 ns/iter (± 2802643) |
580103122 ns/iter (± 5456258) |
1.00 |
tpch_q12/vortex-file-uncompressed |
351868086 ns/iter (± 2213695) |
345643847 ns/iter (± 1139010) |
1.02 |
tpch_q13/vortex-in-memory-no-pushdown |
202357825 ns/iter (± 6705696) |
203100006 ns/iter (± 1202667) |
1.00 |
tpch_q13/vortex-in-memory-pushdown |
199438754 ns/iter (± 2925486) |
202272543 ns/iter (± 2227710) |
0.99 |
tpch_q13/arrow |
197470017 ns/iter (± 4503082) |
199860993 ns/iter (± 1010892) |
0.99 |
tpch_q13/parquet |
327786684 ns/iter (± 2414166) |
321150161 ns/iter (± 2321423) |
1.02 |
tpch_q13/vortex-file-compressed |
234764648 ns/iter (± 903176) |
232334292 ns/iter (± 2416560) |
1.01 |
tpch_q13/vortex-file-uncompressed |
231999363 ns/iter (± 2444117) |
226681788 ns/iter (± 3671643) |
1.02 |
tpch_q14/vortex-in-memory-no-pushdown |
38405029 ns/iter (± 237824) |
38041342 ns/iter (± 266844) |
1.01 |
tpch_q14/vortex-in-memory-pushdown |
91721025 ns/iter (± 450857) |
84985764 ns/iter (± 201870) |
1.08 |
tpch_q14/arrow |
37952027 ns/iter (± 361578) |
39621123 ns/iter (± 190295) |
0.96 |
tpch_q14/parquet |
219878525 ns/iter (± 1528510) |
220810995 ns/iter (± 488198) |
1.00 |
tpch_q14/vortex-file-compressed |
89584624 ns/iter (± 1028671) |
85282407 ns/iter (± 231903) |
1.05 |
tpch_q14/vortex-file-uncompressed |
137791001 ns/iter (± 1219246) |
131449089 ns/iter (± 1028117) |
1.05 |
tpch_q15/vortex-in-memory-no-pushdown |
66606304 ns/iter (± 432197) |
65940852 ns/iter (± 2462241) |
1.01 |
tpch_q15/vortex-in-memory-pushdown |
126692286 ns/iter (± 486636) |
118152782 ns/iter (± 402668) |
1.07 |
tpch_q15/arrow |
63423004 ns/iter (± 211611) |
66268465 ns/iter (± 294144) |
0.96 |
tpch_q15/parquet |
289404560 ns/iter (± 1228712) |
293348631 ns/iter (± 1069079) |
0.99 |
tpch_q15/vortex-file-compressed |
159534083 ns/iter (± 563859) |
150902919 ns/iter (± 771298) |
1.06 |
tpch_q15/vortex-file-uncompressed |
252939321 ns/iter (± 3589101) |
239656687 ns/iter (± 2149877) |
1.06 |
tpch_q16/vortex-in-memory-no-pushdown |
116600318 ns/iter (± 515794) |
120024572 ns/iter (± 1257840) |
0.97 |
tpch_q16/vortex-in-memory-pushdown |
121107287 ns/iter (± 405947) |
124932462 ns/iter (± 858600) |
0.97 |
tpch_q16/arrow |
103066936 ns/iter (± 249223) |
104740905 ns/iter (± 620639) |
0.98 |
tpch_q16/parquet |
120633576 ns/iter (± 398026) |
120747177 ns/iter (± 298536) |
1.00 |
tpch_q16/vortex-file-compressed |
133179243 ns/iter (± 827437) |
136602793 ns/iter (± 1855647) |
0.97 |
tpch_q16/vortex-file-uncompressed |
132126786 ns/iter (± 902307) |
134522659 ns/iter (± 675012) |
0.98 |
tpch_q17/vortex-in-memory-no-pushdown |
639489726 ns/iter (± 12763666) |
638718772 ns/iter (± 10955418) |
1.00 |
tpch_q17/vortex-in-memory-pushdown |
653587193 ns/iter (± 8518564) |
639597385 ns/iter (± 10100137) |
1.02 |
tpch_q17/arrow |
532078928 ns/iter (± 6871463) |
551761624 ns/iter (± 20266138) |
0.96 |
tpch_q17/parquet |
578247032 ns/iter (± 2335804) |
584307536 ns/iter (± 2118768) |
0.99 |
tpch_q17/vortex-file-compressed |
628036383 ns/iter (± 8063930) |
632824200 ns/iter (± 8237594) |
0.99 |
tpch_q17/vortex-file-uncompressed |
669616929 ns/iter (± 4845618) |
669405892 ns/iter (± 7145907) |
1.00 |
tpch_q18/vortex-in-memory-no-pushdown |
1012380891 ns/iter (± 12666098) |
1033575235 ns/iter (± 6480194) |
0.98 |
tpch_q18/vortex-in-memory-pushdown |
1029794532 ns/iter (± 6659002) |
1037954957 ns/iter (± 5525517) |
0.99 |
tpch_q18/arrow |
1017749344 ns/iter (± 6294415) |
1037972202 ns/iter (± 11003393) |
0.98 |
tpch_q18/parquet |
1198487455 ns/iter (± 6933781) |
1241530360 ns/iter (± 11503095) |
0.97 |
tpch_q18/vortex-file-compressed |
1060591685 ns/iter (± 6271270) |
1093574429 ns/iter (± 26661227) |
0.97 |
tpch_q18/vortex-file-uncompressed |
1106656533 ns/iter (± 22171075) |
1135527303 ns/iter (± 5445322) |
0.97 |
tpch_q19/vortex-in-memory-no-pushdown |
171647409 ns/iter (± 382721) |
171371606 ns/iter (± 339968) |
1.00 |
tpch_q19/vortex-in-memory-pushdown |
268814200 ns/iter (± 3242222) |
251379674 ns/iter (± 648908) |
1.07 |
tpch_q19/arrow |
158195210 ns/iter (± 386192) |
155649388 ns/iter (± 642608) |
1.02 |
tpch_q19/parquet |
478133880 ns/iter (± 2574516) |
473303967 ns/iter (± 714626) |
1.01 |
tpch_q19/vortex-file-compressed |
756255304 ns/iter (± 9726230) |
733493167 ns/iter (± 5923432) |
1.03 |
tpch_q19/vortex-file-uncompressed |
376630530 ns/iter (± 2180965) |
355239896 ns/iter (± 1464307) |
1.06 |
tpch_q20/vortex-in-memory-no-pushdown |
250197779 ns/iter (± 1343481) |
261783583 ns/iter (± 1478190) |
0.96 |
tpch_q20/vortex-in-memory-pushdown |
276855282 ns/iter (± 1474710) |
289724725 ns/iter (± 2851372) |
0.96 |
tpch_q20/arrow |
232942372 ns/iter (± 5112235) |
250959662 ns/iter (± 1374796) |
0.93 |
tpch_q20/parquet |
356627742 ns/iter (± 1605437) |
358117754 ns/iter (± 1557295) |
1.00 |
tpch_q20/vortex-file-compressed |
304894518 ns/iter (± 3553530) |
316302946 ns/iter (± 3672732) |
0.96 |
tpch_q20/vortex-file-uncompressed |
370755671 ns/iter (± 2303235) |
380358185 ns/iter (± 2962816) |
0.97 |
tpch_q21/vortex-in-memory-no-pushdown |
851291006 ns/iter (± 4053108) |
864120305 ns/iter (± 8912386) |
0.99 |
tpch_q21/vortex-in-memory-pushdown |
887863596 ns/iter (± 3870211) |
904473866 ns/iter (± 7922233) |
0.98 |
tpch_q21/arrow |
850373472 ns/iter (± 3552977) |
869560644 ns/iter (± 10310287) |
0.98 |
tpch_q21/parquet |
992308342 ns/iter (± 6369854) |
998784037 ns/iter (± 4604918) |
0.99 |
tpch_q21/vortex-file-compressed |
1054057295 ns/iter (± 7057139) |
1050444034 ns/iter (± 7494848) |
1.00 |
tpch_q21/vortex-file-uncompressed |
1066944617 ns/iter (± 8067435) |
1090136459 ns/iter (± 5798952) |
0.98 |
tpch_q22/vortex-in-memory-no-pushdown |
94667372 ns/iter (± 366867) |
94796839 ns/iter (± 426572) |
1.00 |
tpch_q22/vortex-in-memory-pushdown |
94830064 ns/iter (± 390134) |
95069207 ns/iter (± 185798) |
1.00 |
tpch_q22/arrow |
65394845 ns/iter (± 278294) |
65224484 ns/iter (± 267262) |
1.00 |
tpch_q22/parquet |
94430459 ns/iter (± 1082407) |
94415071 ns/iter (± 849064) |
1.00 |
tpch_q22/vortex-file-compressed |
101251118 ns/iter (± 1868238) |
102450843 ns/iter (± 699319) |
0.99 |
tpch_q22/vortex-file-uncompressed |
108720352 ns/iter (± 392982) |
109695231 ns/iter (± 402043) |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some more work after #768