Skip to content

Use async_fs instead of LocalFileSystem in java bindings for local files#7904

Open
robert3005 wants to merge 2 commits into
developfrom
rk/javalocalfs
Open

Use async_fs instead of LocalFileSystem in java bindings for local files#7904
robert3005 wants to merge 2 commits into
developfrom
rk/javalocalfs

Conversation

@robert3005
Copy link
Copy Markdown
Contributor

Found this crate and I think it's a bit more ergonomic than object_store for
local files

Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 12, 2026

Merging this PR will degrade performance by 24.72%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

❌ 6 regressed benchmarks
✅ 1204 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation new_bp_prim_test_between[i16, 32768] 121 µs 135 µs -10.35%
Simulation new_bp_prim_test_between[i32, 16384] 95.5 µs 109.9 µs -13.09%
Simulation new_bp_prim_test_between[i32, 32768] 141.8 µs 170.7 µs -16.93%
Simulation new_alp_prim_test_between[f64, 16384] 127.8 µs 149.7 µs -14.61%
Simulation new_bp_prim_test_between[i64, 32768] 178.9 µs 237.6 µs -24.72%
Simulation new_bp_prim_test_between[i64, 16384] 116 µs 145.3 µs -20.19%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/javalocalfs (b57bfe3) with develop (e56c80d)

Open in CodSpeed

@robert3005 robert3005 added the changelog/chore A trivial change label May 12, 2026
@robert3005 robert3005 enabled auto-merge (squash) May 13, 2026 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant