Skip to content

Add UncompressedSizeInBytes pushdown for all encodings#7953

Draft
AdamGS wants to merge 1 commit into
developfrom
adamg/all-uncompressed-size-fns
Draft

Add UncompressedSizeInBytes pushdown for all encodings#7953
AdamGS wants to merge 1 commit into
developfrom
adamg/all-uncompressed-size-fns

Conversation

@AdamGS
Copy link
Copy Markdown
Contributor

@AdamGS AdamGS commented May 15, 2026

Summary

Closes: #000

Testing

@AdamGS AdamGS added the changelog/performance A performance improvement label May 15, 2026
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS force-pushed the adamg/all-uncompressed-size-fns branch from f5e00a5 to 3821439 Compare May 15, 2026 16:37
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 15, 2026

Merging this PR will degrade performance by 12.09%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 1216 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation encode_varbin[(1000, 2)] 148.5 µs 168.9 µs -12.09%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing adamg/all-uncompressed-size-fns (3821439) with develop (96dda71)

Open in CodSpeed

@tl-dr-review tl-dr-review Bot added the tldr label May 15, 2026
@gatesn gatesn added tldr and removed tldr labels May 15, 2026
@tl-dr-review tl-dr-review Bot added tldr and removed tldr labels May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/performance A performance improvement tldr

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants