Fuzzing Crash: VortexError in file_io#7956
Open
vortex-claude[bot] wants to merge 1 commit into
Open
Conversation
…iffers from array storage type When `between_unpack` could not cast a bound scalar's backing integer value to the array's storage type `T` (e.g. `DecimalValue::I32(82246)` → `i16`), it previously returned `Err(vortex_bail!(...))`. The fuzzer found a case where a `DecimalArray` with `values_type = I16` received a bound stored as `DecimalValue::I32`, causing the error to propagate and the fuzz harness to panic via `vortex_expect`. The fix: return `Ok(None)` instead of `Err(...)` in that case, signalling that this kernel cannot handle the input. `between_canonical` then falls through to the generic Arrow-based comparison path, which compares decimal values semantically by their shared precision and scale and correctly handles mixed storage widths. A regression test exercises the exact scenario from the crash report: an `i16`-backed decimal array compared against bounds backed by `i32`, where the upper bound value (82246) exceeds `i16::MAX`. Fixes #7955 Co-authored-by: Nicholas Gates <gatesn@users.noreply.github.com> Signed-off-by: "Claude" <claude@anthropic.com>
Merging this PR will not alter performance
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | chunked_varbinview_canonical_into[(100, 100)] |
307.8 µs | 273.2 µs | +12.66% |
| ❌ | Simulation | chunked_varbinview_opt_canonical_into[(1000, 10)] |
187.6 µs | 225.4 µs | -16.76% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing claude/issue-7955-20260515-2235 (9ca2250) with develop (d71d3d3)
Contributor
|
Can you compare here without allocating? So iterate the decimal, upcast and compare instead of materialising the upcast? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7955
Generated with Claude Code.
View Claude run