Skip to content

Approving a bot pr will retrigger approval check#7982

Open
robert3005 wants to merge 1 commit into
developfrom
rk/review
Open

Approving a bot pr will retrigger approval check#7982
robert3005 wants to merge 1 commit into
developfrom
rk/review

Conversation

@robert3005
Copy link
Copy Markdown
Contributor

I am trying to remove the need to explicitly retrigger check-approvals
(pull_requeest) for bot authored prs when user approves the change

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 added the changelog/skip Do not list PR in the changelog label May 18, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 18, 2026

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 1 improved benchmark
❌ 3 regressed benchmarks
✅ 1217 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_varbinview_canonical_into[(100, 100)] 273.3 µs 308 µs -11.28%
Simulation chunked_varbinview_opt_canonical_into[(1000, 10)] 225.3 µs 188.1 µs +19.83%
Simulation new_alp_prim_test_between[f32, 16384] 103.8 µs 118.4 µs -12.32%
Simulation new_alp_prim_test_between[f32, 32768] 153.2 µs 182.1 µs -15.9%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/review (e368f48) with develop (d25c33f)

Open in CodSpeed

@robert3005 robert3005 enabled auto-merge (squash) May 18, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/skip Do not list PR in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant