Add pruning aggregate functions#8025
Conversation
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Merging this PR will degrade performance by 13.9%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | new_alp_prim_test_between[f32, 16384] |
103.9 µs | 118.2 µs | -12.04% |
| ❌ | Simulation | new_alp_prim_test_between[f32, 32768] |
153.3 µs | 181.9 µs | -15.72% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing ngates/stats-7707/min-max-aggregate-fns (d99cb3a) with develop (ba5064a)
Review comments carried over from auto-closed #7934#7934 was closed/merged into the stack branch while the stack was being repaired. Copying the review notes here so they remain visible on the replacement PR. Review summaries
Inline review comments
Bot review findings worth preservingFrom Claude first pass:
From Claude second pass:
|
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Adds the pruning aggregate functions used by stats rewrites, bounded string/binary min-max variants, and the aggregate compatibility relation for matching stored bounds to requested bounds.