Skip to content

Avoid re-building vortex-duckdb twice#8035

Merged
myrrc merged 1 commit into
developfrom
adamg/avoid-duckdb-rebuild
May 20, 2026
Merged

Avoid re-building vortex-duckdb twice#8035
myrrc merged 1 commit into
developfrom
adamg/avoid-duckdb-rebuild

Conversation

@AdamGS
Copy link
Copy Markdown
Contributor

@AdamGS AdamGS commented May 20, 2026

Summary

Currently, if you build something like duckdb-bench cargo will rebuild vortex-duckdb once before it'll be satisfied that it doesn't need to rebuild it. The root cause is that cargo's fingerprinting can't accurately track files that are created during the build.

This change is fine because we still track our own changes, the only external change will be something like a duckdb version upgrade which will change build.rs and re-trigger the build as expected.

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS requested review from 0ax1 and myrrc May 20, 2026 14:18
@AdamGS AdamGS added changelog/chore A trivial change ext/duckdb Relates to the DuckDB integration labels May 20, 2026
@myrrc myrrc enabled auto-merge (squash) May 20, 2026 14:21
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 20, 2026

Merging this PR will degrade performance by 16.59%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

❌ 1 regressed benchmark
✅ 1236 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_varbinview_opt_canonical_into[(1000, 10)] 187.7 µs 225.1 µs -16.59%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing adamg/avoid-duckdb-rebuild (b5ba99c) with develop (2033ef5)

Open in CodSpeed

@myrrc myrrc merged commit 008c1d9 into develop May 20, 2026
85 of 87 checks passed
@myrrc myrrc deleted the adamg/avoid-duckdb-rebuild branch May 20, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change ext/duckdb Relates to the DuckDB integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants