Skip to content

Simplify some of the buffer impl#8098

Merged
AdamGS merged 1 commit into
developfrom
adamg/buffer-simplify
May 26, 2026
Merged

Simplify some of the buffer impl#8098
AdamGS merged 1 commit into
developfrom
adamg/buffer-simplify

Conversation

@AdamGS
Copy link
Copy Markdown
Contributor

@AdamGS AdamGS commented May 26, 2026

Summary

Remove a PartialEq impl we don't use and can be expressed with as_ref + derive Clone which generates identical code.

API Changes

None

Testing

Existing tests

@AdamGS AdamGS requested a review from 0ax1 May 26, 2026 10:08
@AdamGS AdamGS added the changelog/chore A trivial change label May 26, 2026
@AdamGS AdamGS enabled auto-merge (squash) May 26, 2026 10:09
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS force-pushed the adamg/buffer-simplify branch from 47f3be2 to 6bfe545 Compare May 26, 2026 10:11
@AdamGS AdamGS merged commit dbfe521 into develop May 26, 2026
61 checks passed
@AdamGS AdamGS deleted the adamg/buffer-simplify branch May 26, 2026 10:21
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 26, 2026

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 1249 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_varbinview_canonical_into[(100, 100)] 273.2 µs 307.9 µs -11.28%
Simulation chunked_varbinview_opt_canonical_into[(1000, 10)] 225.1 µs 187.8 µs +19.87%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing adamg/buffer-simplify (6bfe545) with develop (fa4245e)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants