Skip to content

like stat falsification respects escape characters#8103

Merged
onursatici merged 3 commits into
developfrom
os/like-stats
May 26, 2026
Merged

like stat falsification respects escape characters#8103
onursatici merged 3 commits into
developfrom
os/like-stats

Conversation

@onursatici
Copy link
Copy Markdown
Contributor

Summary

In pruning of like expressions. We didn't remove the escape characters in the pattern, so we were getting wrong prefixes and exact patterns forwarded to further stat falsification

Testing

unit tests

Signed-off-by: Onur Satici <onur@spiraldb.com>
Signed-off-by: Onur Satici <onur@spiraldb.com>
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 26, 2026

Merging this PR will degrade performance by 10.46%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 1 improved benchmark
❌ 8 regressed benchmarks
✅ 1242 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_varbinview_canonical_into[(100, 100)] 273.2 µs 307.9 µs -11.29%
Simulation chunked_varbinview_opt_canonical_into[(1000, 10)] 225.1 µs 187.6 µs +19.99%
Simulation encode_varbin[(1000, 2)] 142.2 µs 163.2 µs -12.87%
Simulation encode_varbin[(1000, 32)] 149.6 µs 166.9 µs -10.4%
Simulation encode_varbin[(1000, 4)] 142.8 µs 164.1 µs -12.99%
Simulation encode_varbin[(1000, 8)] 143.9 µs 161.6 µs -10.98%
Simulation take_map[(0.1, 0.1)] 452.3 µs 517.1 µs -12.53%
Simulation take_map[(0.1, 0.5)] 980.9 µs 1,134.5 µs -13.54%
Simulation take_map[(0.1, 1.0)] 1.7 ms 2.2 ms -24.02%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing os/like-stats (a3d0725) with develop (94d1f5a)

Open in CodSpeed

@onursatici onursatici added the changelog/fix A bug fix label May 26, 2026
@robert3005 robert3005 requested a review from joseph-isaacs May 26, 2026 13:28
@robert3005
Copy link
Copy Markdown
Contributor

I have added a bail logic to the fsst dfa transform. It might be useful to apply the same fix there so we get support

Signed-off-by: Onur Satici <onur@spiraldb.com>
@onursatici onursatici enabled auto-merge (squash) May 26, 2026 14:04
@onursatici onursatici merged commit 4823563 into develop May 26, 2026
61 checks passed
@onursatici onursatici deleted the os/like-stats branch May 26, 2026 14:12
@onursatici
Copy link
Copy Markdown
Contributor Author

fsst dfa fix here: #8107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants