like stat falsification respects escape characters#8103
Merged
Conversation
Signed-off-by: Onur Satici <onur@spiraldb.com>
Signed-off-by: Onur Satici <onur@spiraldb.com>
Merging this PR will degrade performance by 10.46%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | chunked_varbinview_canonical_into[(100, 100)] |
273.2 µs | 307.9 µs | -11.29% |
| ⚡ | Simulation | chunked_varbinview_opt_canonical_into[(1000, 10)] |
225.1 µs | 187.6 µs | +19.99% |
| ❌ | Simulation | encode_varbin[(1000, 2)] |
142.2 µs | 163.2 µs | -12.87% |
| ❌ | Simulation | encode_varbin[(1000, 32)] |
149.6 µs | 166.9 µs | -10.4% |
| ❌ | Simulation | encode_varbin[(1000, 4)] |
142.8 µs | 164.1 µs | -12.99% |
| ❌ | Simulation | encode_varbin[(1000, 8)] |
143.9 µs | 161.6 µs | -10.98% |
| ❌ | Simulation | take_map[(0.1, 0.1)] |
452.3 µs | 517.1 µs | -12.53% |
| ❌ | Simulation | take_map[(0.1, 0.5)] |
980.9 µs | 1,134.5 µs | -13.54% |
| ❌ | Simulation | take_map[(0.1, 1.0)] |
1.7 ms | 2.2 ms | -24.02% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing os/like-stats (a3d0725) with develop (94d1f5a)
Contributor
|
I have added a bail logic to the fsst dfa transform. It might be useful to apply the same fix there so we get support |
robert3005
approved these changes
May 26, 2026
Signed-off-by: Onur Satici <onur@spiraldb.com>
Contributor
Author
|
fsst dfa fix here: #8107 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In pruning of like expressions. We didn't remove the escape characters in the pattern, so we were getting wrong prefixes and exact patterns forwarded to further stat falsification
Testing
unit tests