Skip to content

feat: support nullable Arrow Device array export#8104

Open
0ax1 wants to merge 8 commits into
developfrom
ad/cudf3-null-masks
Open

feat: support nullable Arrow Device array export#8104
0ax1 wants to merge 8 commits into
developfrom
ad/cudf3-null-masks

Conversation

@0ax1
Copy link
Copy Markdown
Contributor

@0ax1 0ax1 commented May 26, 2026

No description provided.

@0ax1 0ax1 requested a review from onursatici May 26, 2026 14:25
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 26, 2026

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
❌ 2 regressed benchmarks
✅ 1248 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_varbinview_opt_into_canonical[(1000, 10)] 239.6 µs 203 µs +17.99%
Simulation chunked_varbinview_opt_canonical_into[(1000, 10)] 187.5 µs 224.2 µs -16.38%
Simulation baseline_lt[16, 65536] 217.6 µs 245.4 µs -11.34%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ad/cudf3-null-masks (2d89c69) with develop (6ddc4d5)

Open in CodSpeed

@0ax1 0ax1 marked this pull request as draft May 26, 2026 14:53
@0ax1 0ax1 added the changelog/feature A new feature label May 26, 2026
@0ax1 0ax1 force-pushed the ad/cudf3-null-masks branch from 832bdd5 to 2c325b3 Compare May 26, 2026 15:21
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
@0ax1 0ax1 force-pushed the ad/cudf3-null-masks branch from 2c325b3 to 00b9508 Compare May 26, 2026 15:22
@0ax1 0ax1 marked this pull request as ready for review May 26, 2026 15:23
@0ax1 0ax1 requested a review from robert3005 May 26, 2026 15:29
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
@0ax1 0ax1 enabled auto-merge (squash) May 26, 2026 15:36
Comment thread vortex-cuda/src/arrow/canonical.rs Outdated
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Comment thread vortex-cuda/src/arrow/canonical.rs Outdated
Comment thread vortex-cuda/src/arrow/canonical.rs Outdated
0ax1 added 3 commits May 26, 2026 16:11
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
@0ax1 0ax1 requested review from onursatici and robert3005 May 26, 2026 16:37
Copy link
Copy Markdown
Contributor

@robert3005 robert3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I originally missed something here. I don't understand why the offseting logic is necessary, that's how the buffers are laid out already

Comment thread vortex-cuda/src/arrow/canonical.rs Outdated
Comment thread vortex-cuda/src/arrow/canonical.rs Outdated
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
@0ax1 0ax1 requested a review from robert3005 May 26, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants