Skip to content

Remove pre df 53.0 polarsignals benchmark workaround #8122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robert3005 merged 1 commit into from
May 27, 2026
+1 −11
Merged

Remove pre df 53.0 polarsignals benchmark workaround #8122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions benchmarks/datafusion-bench/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,18 +268,8 @@ async fn register_benchmark_tables<B: Benchmark + ?Sized>(
let pattern = benchmark.pattern(table.name, format);
let table_url = ListingTableUrl::try_new(benchmark_base.clone(), pattern)?;

let mut listing_options = ListingOptions::new(Arc::clone(&file_format))
let listing_options = ListingOptions::new(Arc::clone(&file_format))
.with_session_config_options(session.state().config());
if benchmark.dataset_name() == "polarsignals" && format == Format::Parquet {
Copy link
Copy Markdown
Contributor

@AdamGS AdamGS May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just realized we don't even run this combo

// Work around a DataFusion bug (fixed in 53.0.0) where the
// constant-column optimization extracts ScalarValues using
// the statistic scalar type, which may not match the table
// column type.
// See: https://github.com/apache/datafusion/pull/20042
// TODO(asubiotto): Remove this after the datafusion 53
// upgrade.
listing_options = listing_options.with_collect_stat(false);
}
let mut config =
ListingTableConfig::new(table_url).with_listing_options(listing_options);

Expand Down
Loading