Skip to content

Correctly handle Nan/Inf comparison in ALP between reduce#8126

Merged
robert3005 merged 3 commits into
developfrom
rk/nancompar
May 27, 2026
Merged

Correctly handle Nan/Inf comparison in ALP between reduce#8126
robert3005 merged 3 commits into
developfrom
rk/nancompar

Conversation

@robert3005
Copy link
Copy Markdown
Contributor

Found in #8105. ALP comparisons to NaN/Inf can be trivially folded since those
values must exist in patches

Signed-off-by: Robert Kruszewski <github@robertk.io>
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 27, 2026

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 1266 untouched benchmarks


Comparing rk/nancompar (350858f) with develop (39fd9e6)

Open in CodSpeed

Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 enabled auto-merge (squash) May 27, 2026 13:44
@robert3005 robert3005 merged commit 7bfe690 into develop May 27, 2026
61 checks passed
@robert3005 robert3005 deleted the rk/nancompar branch May 27, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants