Skip to content

ffi: remove vx_file scan#8152

Merged
myrrc merged 1 commit into
developfrom
myrrc/ffi-rm-old-scan
May 29, 2026
Merged

ffi: remove vx_file scan#8152
myrrc merged 1 commit into
developfrom
myrrc/ffi-rm-old-scan

Conversation

@myrrc
Copy link
Copy Markdown
Contributor

@myrrc myrrc commented May 29, 2026

Users should use vx_data_source and vx_scan.
write_array is retained until we have proper file writing FFI

@myrrc myrrc force-pushed the myrrc/ffi-rm-old-scan branch from f78eec0 to d4ac6e5 Compare May 29, 2026 12:52
@myrrc myrrc requested a review from 0ax1 May 29, 2026 12:52
@myrrc myrrc added changelog/chore A trivial change lang/c Relates to the Vortex C (FFI) API labels May 29, 2026
@myrrc myrrc enabled auto-merge (squash) May 29, 2026 12:52
@myrrc myrrc added changelog/break A breaking API change and removed changelog/chore A trivial change labels May 29, 2026
@myrrc myrrc force-pushed the myrrc/ffi-rm-old-scan branch 2 times, most recently from d615f66 to 92d6d29 Compare May 29, 2026 13:00
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc myrrc force-pushed the myrrc/ffi-rm-old-scan branch from 92d6d29 to f19d8fa Compare May 29, 2026 13:03
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 29, 2026

Merging this PR will improve performance by 19.84%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 1 improved benchmark
✅ 1265 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_varbinview_opt_canonical_into[(1000, 10)] 225.4 µs 188.1 µs +19.84%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing myrrc/ffi-rm-old-scan (f19d8fa) with develop (6e6fb1d)

Open in CodSpeed

@myrrc myrrc merged commit d44240e into develop May 29, 2026
66 checks passed
@myrrc myrrc deleted the myrrc/ffi-rm-old-scan branch May 29, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/break A breaking API change lang/c Relates to the Vortex C (FFI) API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants