Skip to content

Always try compressing extension array's storage directly#8157

Merged
connortsui20 merged 1 commit into
developfrom
adamg/ext-compression-fix
May 29, 2026
Merged

Always try compressing extension array's storage directly#8157
connortsui20 merged 1 commit into
developfrom
adamg/ext-compression-fix

Conversation

@AdamGS
Copy link
Copy Markdown
Contributor

@AdamGS AdamGS commented May 29, 2026

Summary

The existing logic will always take the first smaller extension-specific scheme, even if directly compressing the storage array is even smaller.

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS requested a review from connortsui20 May 29, 2026 14:39
@AdamGS AdamGS added the changelog/fix A bug fix label May 29, 2026
@connortsui20 connortsui20 enabled auto-merge (squash) May 29, 2026 14:45
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 29, 2026

Merging this PR will improve performance by 19.85%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 1 improved benchmark
✅ 1265 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_varbinview_opt_canonical_into[(1000, 10)] 225.4 µs 188.1 µs +19.85%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing adamg/ext-compression-fix (5357070) with develop (084f327)

Open in CodSpeed

@connortsui20 connortsui20 merged commit c005aae into develop May 29, 2026
70 of 71 checks passed
@connortsui20 connortsui20 deleted the adamg/ext-compression-fix branch May 29, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants